Skip to content

DataTableToolbar: bake in default bottom spacing between toolbar and table #1719

Description

@leecalcote

Current Behavior

DataTableToolbar renders flush against the table below it. Every consumer ends up adding the same inline override at each call site:

<DataTableToolbar sx={{ mb: 2 }} ... />

In meshery-cloud this was repeated at 17 call sites (see layer5io/meshery-cloud#5740 and the review thread there); we consolidated it into a local wrapper (ui/components/general/data-table-toolbar.tsx) as a stopgap.

Desired Behavior

The toolbar-to-table gap should be the component's default so every consumer inherits it without per-call-site overrides. Callers with special layouts can still override via sx.

Suggested: apply marginBottom: theme.spacing(2) in DataTableToolbar's root styles, keeping sx merge order so caller values win.

Follow-up

Once released, meshery-cloud can delete its wrapper and import DataTableToolbar from @sistent/sistent directly again.

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions