Skip to content

Commit 799923f

Browse files
committed
Perftest: Update Enhanced Reorder term
Signed-off-by: Shmuel Shaul <[email protected]>
1 parent 0c5918d commit 799923f

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

src/perftest_parameters.c

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -538,7 +538,7 @@ static void usage(const char *argv0, VerbType verb, TestType tst, int connection
538538
#endif
539539

540540
#ifdef HAVE_OOO_RECV_WRS
541-
printf(" --no_ddp ");
541+
printf(" --no_enhanced_reorder ");
542542
printf(" Disable the receiver capability to consume out-of-order WRs. (SYMMETRIC)\n");
543543
#endif
544544

@@ -1001,8 +1001,8 @@ static void init_perftest_params(struct perftest_parameters *user_param)
10011001
user_param->use_unsolicited_write = 0;
10021002
user_param->congest_type = OFF;
10031003
user_param->no_lock = OFF;
1004-
user_param->use_ddp = OFF;
1005-
user_param->no_ddp = OFF;
1004+
user_param->use_enhanced_reorder = OFF;
1005+
user_param->no_enhanced_reorder = OFF;
10061006
user_param->connectionless = OFF;
10071007
user_param->cqe_poll = CTX_POLL_BATCH;
10081008
user_param->use_cqe_poll = OFF;
@@ -2632,7 +2632,7 @@ int parser(struct perftest_parameters *user_param,char *argv[], int argc)
26322632
static int no_lock_flag = 0;
26332633
#endif
26342634
#ifdef HAVE_OOO_RECV_WRS
2635-
static int no_ddp_flag = 0;
2635+
static int no_enhanced_reorder_flag = 0;
26362636
#endif
26372637
static int connectionless_flag = 0;
26382638
static int cqe_poll_flag = 0;
@@ -2813,7 +2813,7 @@ int parser(struct perftest_parameters *user_param,char *argv[], int argc)
28132813
{.name = "bind_source_ip", .has_arg = 1, .flag = &source_ip_flag, .val = 1},
28142814
{.name = "write_with_imm", .has_arg = 0, .flag = &use_write_with_imm_flag, .val = 1 },
28152815
#ifdef HAVE_OOO_RECV_WRS
2816-
{ .name = "no_ddp", .has_arg = 0, .flag = &no_ddp_flag, .val = 1},
2816+
{ .name = "no_enhanced_reorder", .has_arg = 0, .flag = &no_enhanced_reorder_flag, .val = 1},
28172817
#endif
28182818
#ifdef HAVE_SRD_WITH_UNSOLICITED_WRITE_RECV
28192819
{.name = "unsolicited_write", .has_arg = 0, .flag = &unsolicited_write_flag, .val = 1 },
@@ -3654,8 +3654,8 @@ int parser(struct perftest_parameters *user_param,char *argv[], int argc)
36543654
#endif
36553655

36563656
#ifdef HAVE_OOO_RECV_WRS
3657-
if (no_ddp_flag) {
3658-
user_param->no_ddp = 1;
3657+
if (no_enhanced_reorder_flag) {
3658+
user_param->no_enhanced_reorder = 1;
36593659
}
36603660
#endif
36613661

@@ -4031,7 +4031,7 @@ void ctx_print_test_info(struct perftest_parameters *user_param)
40314031
#endif //HAVE_TD_API
40324032
#endif
40334033

4034-
printf(" ibv_wr* API : %s\t\tUsing DDP : %s\n", user_param->use_old_post_send ? "OFF" : "ON", user_param->use_ddp ? "ON" : "OFF");
4034+
printf(" ibv_wr* API : %s\t\tUsing Enhanced Reorder : %s\n", user_param->use_old_post_send ? "OFF" : "ON", user_param->use_enhanced_reorder ? "ON" : "OFF");
40354035
if (user_param->machine == CLIENT || user_param->duplex) {
40364036
printf(" TX depth : %d\n",user_param->tx_depth);
40374037
}

src/perftest_parameters.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -674,8 +674,8 @@ struct perftest_parameters {
674674
int ah_allocated;
675675
int use_write_with_imm;
676676
int use_unsolicited_write;
677-
int use_ddp;
678-
int no_ddp;
677+
int use_enhanced_reorder;
678+
int no_enhanced_reorder;
679679
int connectionless;
680680
uint16_t cqe_poll;
681681
int use_cqe_poll;

src/perftest_resources.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2766,7 +2766,7 @@ struct ibv_qp* ctx_qp_create(struct pingpong_context *ctx,
27662766
// OOO_RECV_WRS is not supported by non-mlnx devices
27672767
is_mlnx_device = get_device_vendor(ctx->context) == 0x02c9;
27682768

2769-
if (!user_param->no_ddp && is_mlnx_device && user_param->connection_type != UD && user_param->connection_type != UC){
2769+
if (!user_param->no_enhanced_reorder && is_mlnx_device && user_param->connection_type != UD && user_param->connection_type != UC){
27702770
ctx_dv.comp_mask = MLX5DV_CONTEXT_MASK_OOO_RECV_WRS;
27712771

27722772
int ret = mlx5dv_query_device(ctx->context, &ctx_dv);
@@ -2783,7 +2783,7 @@ struct ibv_qp* ctx_qp_create(struct pingpong_context *ctx,
27832783
fprintf(stderr, "RX Depth=%d must not exceed the maximal OOO receive WR's\n", user_param->rx_depth);
27842784
return NULL;
27852785
}
2786-
user_param->use_ddp = ON;
2786+
user_param->use_enhanced_reorder = ON;
27872787
attr_dv.create_flags |= MLX5DV_QP_CREATE_OOO_DP;
27882788
attr_dv.comp_mask |= MLX5DV_QP_INIT_ATTR_MASK_QP_CREATE_FLAGS;
27892789
}

0 commit comments

Comments
 (0)