Skip to content

Fix more Clang 21.1 lint warnings #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hekota merged 4 commits into from
Dec 8, 2025
+3 −3
Merged

Fix more Clang 21.1 lint warnings #550

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1a36394
Fix more Clang 21.1 lint warnings
hekota Dec 2, 2025
f1f6b42
code review feedback - add const
hekota Dec 5, 2025
8815d85
Merge branch 'main' into more-clang21-warnings
hekota Dec 8, 2025
f8241b1
clang-format
hekota Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions lib/API/DX/Device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1022,7 +1022,8 @@ class DXDevice : public offloadtest::Device {
HR::toError(IS.CmdList->Close(), "Failed to close command list."))
return Err;

ID3D12CommandList *CmdLists[] = {IS.CmdList.Get()};
ID3D12CommandList *CmdLists[] = {
IS.CmdList.Get()}; // NOLINT(misc-const-correctness)
IS.Queue->ExecuteCommandLists(1, CmdLists);

return waitForSignal(IS);
Expand Down Expand Up @@ -1213,13 +1214,13 @@ class DXDevice : public offloadtest::Device {
static_cast<uint32_t>(B.getElementSize() * B.OutputProps.Width);
const uint32_t Height = static_cast<uint32_t>(B.OutputProps.Height);

uint8_t *SrcBase = reinterpret_cast<uint8_t *>(Mapped);
const uint8_t *SrcBase = reinterpret_cast<uint8_t *>(Mapped);
uint8_t *DstBase =
reinterpret_cast<uint8_t *>(P.Bindings.RTargetBufferPtr->Data[0].get());

// Copy rows in reverse order.
for (uint32_t Y = 0; Y < Height; ++Y) {
uint8_t *SrcRow = SrcBase + static_cast<size_t>(Y) * RowPitch;
const uint8_t *SrcRow = SrcBase + static_cast<size_t>(Y) * RowPitch;
uint8_t *DstRow =
DstBase + static_cast<size_t>(Height - 1 - Y) * RowBytes;
memcpy(DstRow, SrcRow, RowBytes);
Expand Down
Loading