Skip to content

[MAINT] Github Actions Reunification - setup-di-compileΒ #334

@damienwebdev

Description

@damienwebdev

Action: setup-di-compile

Status: πŸ”΄ Refactor β€” remove embedded PHP setup and checkout
Files: setup-di-compile/action.yml


Context

Graycore removed setup-di-compile entirely (feat!: remove unmaintained setup-di-compile action, Feb 2026). The mage-os fork retains it but needs the same lean treatment applied to coding-standard (feat(coding-standard)!: remove pr-diff feature and built-in php setup): strip embedded checkout and PHP setup, let calling workflows own those concerns.


Current problems

Area Current (mage-os) Target
php_version / composer_version inputs Present β€” drives embedded PHP setup Remove; caller handles PHP setup
actions/checkout@v3 step Embedded in action Remove; caller must checkout
shivammathur/setup-php@v2 step Embedded in action Remove
cache-magento mode: 'store' Uses deprecated mode input Remove mode: (aligns with action-cache-magento.md)
tj-actions/changed-files@v39 Gates all steps on changed files Remove β€” action always runs

Dependents

Repo Risk
ryansunxl/mageos-magento2 Uses setup-di-compile β€” callers must add PHP setup before using the action
mage-os/mageos-magento2 Uses setup-di-compile β€” same

Removing php_version / composer_version inputs is a breaking change. Coordinate with or open PRs in both repos to add a shivammathur/setup-php@v2 step before the setup-di-compile call.


Changes needed

  1. Remove actions/checkout step β€” caller is responsible for checkout
  2. Remove shivammathur/setup-php@v2 step β€” caller is responsible for PHP/composer setup
  3. Remove php_version and composer_version inputs
  4. Remove mode: 'store' from the cache-magento call (after update-cache-magento PR merges)
  5. Remove tj-actions/changed-files step and all if: steps.changed-files.outputs.magento_any_changed == 'true' conditions β€” action always runs unconditionally
  6. Open migration PRs in ryansunxl/mageos-magento2 and mage-os/mageos-magento2 before or alongside this change

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions