Feature: Return namedtuples for get_format_args

[wcooley]

The nested tuple/list structures that are returned by get_format_args are fairly cumbersome; returning data namedtuple makes accessing the data much cleaner.

I am a bit uncertain about the field names themselves - - I chose 'positional' and 'named' because the documentation for the function describes them that way, but I chose 'key' and 'index' for the component (rather than 'position' and 'name') because those are the standard way to refer to them. It seems a bit inconsistent, however -- perhaps the FormatArgs fields should be indexed and keyed? (or "...s" instead of "...ed"?)

[wcooley]

Also, I tested this locally with py27, py35 and pypy. (I don't have py34 and I couldn't get the py26 virtualenv to build.)

[mahmoud]

This seems like a pretty innocuous and helpful change, thank you! I just had one change, to comply with the boltons integration architecture.

[mahmoud]

can you change this to:

try:
    from boltons.namedutils import namedtuple
except ImportError:
    from collections import namedtuple

This will allow the module to continue to be used both inside and outside of the boltons package.

[wcooley]

Done. It also occurs to me that I have also neglected to update the documentation.

[mahmoud]

hehe this inline parametrize is kind of long, just curious, is this common practice with pytest?

[wcooley]

I assume so; the pytest docs show an example of a multi-line parametrize right at the top. There are also a few instances in the pytest tests themselves (such as in test_conftest.py, test_config.py and test_mark.py).

If I have something like this that I intend to reuse exactly as-is, rather than moving the list of samples to a separate variable, I create a new mark:

pytest.mark.get_format_samples = pytest.mark.parametrize(('sample', 'expected), ...

[mahmoud]

Interesting, thanks!