Code review comments

Author: stkillen

src/Tools/AI Test Toolkit/src/AITCommandLineCard.Page.al

@@ -46,10 +46,10 @@ page 149042 "AIT CommandLine Card"
                         UpdateAITestMethodLines();
                     end;
                 }
-                field("Language Tag"; LanguageTag)
+                field("Language Tag"; LanguageTagFilter)
                 {
-                    Caption = 'Language Tag';
-                    ToolTip = 'Specifies the language tag for the test method lines.';
+                    Caption = 'Language';
+                    ToolTip = 'Specifies the language to run.';
 
                     trigger OnValidate()
                     var
@@ -61,7 +61,7 @@ page 149042 "AIT CommandLine Card"
 
                         Clear(LineNoFilter);
 
-                        AITTestSuite.Validate("Language ID", AITTestSuiteLanguage.GetLanguageIDByTag(LanguageTag));
+                        AITTestSuite.Validate("Language ID", AITTestSuiteLanguage.GetLanguageIDByTag(LanguageTagFilter));
                         AITTestSuite.Modify(true);
 
                         UpdateAITestMethodLines();
@@ -295,7 +295,7 @@ page 149042 "AIT CommandLine Card"
         CannotFindAITSuiteErr: Label 'The specified Test Suite with code %1 cannot be found.', Comment = '%1 = Test Suite id.';
         AITCode: Code[100];
         LineNoFilter: Integer;
-        LanguageTag: Text[80];
+        LanguageTagFilter: Text[80];
         NoOfPendingTests: Integer;
         InputDataset: Text;
         SuiteDefinition: Text;

src/Tools/AI Test Toolkit/src/TestSuite/AITALTestSuiteMgt.Codeunit.al

@@ -255,7 +255,6 @@ codeunit 149037 "AIT AL Test Suite Mgt"
         ImportTestInputs(DatasetFileName, DatasetInStream, CallerModuleInfo, LanguageID, DatasetFileName);
     end;
 
-
     /// <summary>
     /// Import the Test Input Dataset from an InStream of a dataset in a supported format with a specific language.
     /// Overwrite the dataset if the dataset with same filename is already imported by the same app

src/Tools/AI Test Toolkit/src/TestSuite/AITRunFrequency.Enum.al

@@ -61,11 +61,6 @@ page 149031 "AIT Test Suite"
                 {
                     ApplicationArea = All;
                 }
-                field("Run Frequency"; Rec."Run Frequency")
-                {
-                    ApplicationArea = All;
-                    ToolTip = 'Specifies how frequently the test suite should be run.';
-                }
                 field("Language Tag"; Language)
                 {
                     ApplicationArea = All;

src/Tools/AI Test Toolkit/src/TestSuite/AITTestSuite.Page.al

@@ -119,11 +119,6 @@ table 149030 "AIT Test Suite"
             Caption = 'Copilot Capability';
             ToolTip = 'Specifies the Copilot Capability that the test suite tests.';
         }
-        field(15; "Run Frequency"; Enum "AIT Run Frequency")
-        {
-            Caption = 'Run Frequency';
-            ToolTip = 'Specifies how frequently the test suite should be run.';
-        }
         field(16; "Base Version"; Integer)
         {
             Caption = 'Base Version';

src/Tools/AI Test Toolkit/src/TestSuite/AITTestSuite.Table.al

@@ -66,10 +66,6 @@ xmlport 149031 "AIT Test Suite Import/Export"
                 {
                     Occurrence = Optional;
                 }
-                fieldattribute(Frequency; "AITSuite"."Run Frequency")
-                {
-                    Occurrence = Optional;
-                }
                 textattribute(DefaultLanguage)
                 {
                     Occurrence = Optional;

src/Tools/AI Test Toolkit/src/TestSuite/AITTestSuiteImportExport.XmlPort.al

@@ -24,13 +24,11 @@ codeunit 149046 "AIT Test Suite Language"
     begin
         AddLanguagesFromTestSuite(AITTestSuite);
 
-        // Verify language is available for the test suite
         if not AITTestSuiteLanguage.Get(AITTestSuite.Code, AITTestSuite."Language ID") then
             Error(LanguageNotAvailableErr, AITTestSuite."Language ID", AITTestSuite.Code);
 
         AITTestMethodLine.SetRange("Test Suite Code", AITTestSuite.Code);
 
-        // Update test method lines to use the selected language version
         if AITTestMethodLine.FindSet() then
             repeat
                 UpdateLanguageForTestMethodLine(AITTestMethodLine, AITTestSuiteLanguage);
@@ -49,15 +47,12 @@ codeunit 149046 "AIT Test Suite Language"
         InputDatasetNotFoundErr: Label 'Input Dataset %1 not found in Test Input Groups.', Comment = '%1 - input dataset.';
         NoLocalizedVersionErr: Label 'No localized version found for Input Dataset %1 in Language ID %2.', Comment = '%1 - input dataset, %2 - language ID.';
     begin
-        // Only update test method lines with input datasets
         if AITTestMethodLine."Input Dataset" = '' then
             exit;
 
-        // Verify that the input dataset exists
         if not TestInputGroup.Get(AITTestMethodLine."Input Dataset") then
             Error(InputDatasetNotFoundErr, AITTestMethodLine."Input Dataset");
 
-        // Update input dataset to language version
         TestInputGroupLanguageVersion.SetRange("Group Name", TestInputGroup."Group Name");
         TestInputGroupLanguageVersion.SetRange("Language ID", AITTestSuiteLanguage."Language ID");
         if not TestInputGroupLanguageVersion.FindFirst() then
@@ -80,7 +75,6 @@ codeunit 149046 "AIT Test Suite Language"
     begin
         AITTestMethodLine.SetRange("Test Suite Code", AITTestSuite.Code);
 
-        // Update available languages based on test method lines in the test suite
         if AITTestMethodLine.FindSet() then
             repeat
                 if AddLanguagesFromTestMethodLine(AITTestMethodLine) then
@@ -179,7 +173,6 @@ codeunit 149046 "AIT Test Suite Language"
     var
         AITTestSuiteLanguage: Record "AIT Test Suite Language";
     begin
-        AITTestSuiteLanguage.Init();
         AITTestSuiteLanguage."Test Suite Code" := TestSuiteCode;
         AITTestSuiteLanguage."Language ID" := LanguageID;
         AITTestSuiteLanguage.Insert(true);

src/Tools/AI Test Toolkit/src/TestSuite/AITTestSuiteLanguage.Codeunit.al

@@ -168,20 +168,17 @@ table 130454 "Test Input Group"
         DefaultGroup: Record "Test Input Group";
         AllGroupsWithSameName: Record "Test Input Group";
     begin
-        // Only update parent groups if this record doesn't already have a parent
         if Rec."Parent Group Code" <> '' then
             exit;
 
-        // Find if there's already a group with the same Group Name
         ExistingGroup.SetRange("Group Name", Rec."Group Name");
         ExistingGroup.SetFilter(Code, '<>%1', Rec.Code);
 
         if not ExistingGroup.FindFirst() then
-            exit; // No existing group with same name, nothing to do
+            exit;
 
         // Check if current record is default language - it should become parent of all
         if Rec."Language ID" = GetDefaultLanguageID() then begin
-            // This is default language, make it the parent of all others with same Group Name
             AllGroupsWithSameName.SetRange("Group Name", Rec."Group Name");
             AllGroupsWithSameName.SetFilter(Code, '<>%1', Rec.Code);
             if AllGroupsWithSameName.FindSet(true) then
@@ -190,13 +187,11 @@ table 130454 "Test Input Group"
                     AllGroupsWithSameName.Modify(true);
                 until AllGroupsWithSameName.Next() = 0;
         end else begin
-            // This is not default language, find the default language group and make it the parent
             DefaultGroup.SetRange("Group Name", Rec."Group Name");
             DefaultGroup.SetRange("Language ID", GetDefaultLanguageID());
             if DefaultGroup.FindFirst() then
                 Validate(Rec."Parent Group Code", DefaultGroup.Code)
             else begin
-                // No default language version exists yet, use the first existing group that has no parent as parent
                 ExistingGroup.SetRange("Group Name", Rec."Group Name");
                 ExistingGroup.SetFilter(Code, '<>%1', Rec.Code);
                 ExistingGroup.SetRange("Parent Group Code", '');