Skip to content

Conversation

@vmichal
Copy link
Contributor

@vmichal vmichal commented Dec 7, 2025

When parsing expected_results.txt for some test suite, the python script was not ready to handle the following issues:

  • Missing result code (only file name present) yielded generic "AttributeError: 'NoneType' object has no attribute 'group'" when attempting to access regex match groups.
  • Typo in result code yielded "AttributeError: module 'stl.test.tests' has no attribute", which is arguably better, but still could be better.

Both issues are quite easy to trigger when experimenting with a larger number of tests, so user-friendly error messages seem like a nice touch.

@vmichal vmichal requested a review from a team as a code owner December 7, 2025 23:32
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews Dec 7, 2025
@StephanTLavavej StephanTLavavej added the test Related to test code label Dec 8, 2025
@StephanTLavavej StephanTLavavej self-assigned this Dec 8, 2025
@vmichal
Copy link
Contributor Author

vmichal commented Dec 8, 2025

BTW I am more than open to alternative wording of error messages. I experimented with a few alternatives and this one I disliked the least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Related to test code

Projects

Status: Initial Review

Development

Successfully merging this pull request may close these issues.

2 participants