move Insight types to new file

Author: danmarshall

packages/sanddance-specs/src/index.ts

@@ -6,5 +6,6 @@
 export * from './build.js';
 export * from './constants.js';
 export * from './inference.js';
+export * from './insight.js';
 export * from './interfaces.js';
 export * from './types.js';

packages/sanddance-specs/src/inference.ts

@@ -4,7 +4,8 @@
 */
 
 import { Column } from '@msrvida/chart-types';
-import { Insight, SpecColumns } from './types.js';
+import { SpecColumns } from './types.js';
+import { Insight } from './insight.js';
 
 export { getColumnsFromData, getStats, inferAll } from '@msrvida/data-inference';
 

packages/sanddance-specs/src/insight.ts

@@ -0,0 +1,73 @@
+/*!
+* Copyright (c) Microsoft Corporation.
+* Licensed under the MIT License.
+*/
+
+import { Size, View } from '@msrvida/chart-types';
+import { Search } from '@msrvida/search-expression';
+import { Transforms } from 'vega-typings';
+import { BackgroundImage, Chart, ColorBin, FacetStyle, SignalValues, TotalStyle } from './types';
+
+/**
+ * Options to designate a SandDance visualization.
+ */
+export interface Insight {
+    backgroundImage?: BackgroundImage;
+    chart: Chart;
+    size: Size;
+    columns: InsightColumns;
+    view?: View;
+    filter?: Search;
+    facetStyle?: FacetStyle;
+    totalStyle?: TotalStyle;
+
+    /**
+     * Type of color binning to use on color scale. Only applicable when the column in the color role is quantitative. 
+     */
+    colorBin?: ColorBin;
+
+    /**
+     * Name of the color scheme. See https://vega.github.io/vega/docs/schemes/
+     */
+    scheme?: string;
+
+    /**
+     * Vega signal values for this insight.
+     */
+    signalValues?: SignalValues;
+
+    /**
+     * Optional flag to hide axes.
+     */
+    hideAxes?: boolean;
+
+    /**
+     * Optional flag to hide legend.
+     */
+    hideLegend?: boolean;
+
+    /**
+     * Optional flag to use CSS colors directly from data.
+     */
+    directColor?: boolean;
+
+    /**
+     * Optional array of Vega transforms to apply to the data.
+     */
+    transform?: Transforms[];
+}
+
+export type InsightColumnRoles = 'uid' | 'x' | 'y' | 'z' | 'group' | 'size' | 'color' | 'facet' | 'facetV' | 'sort';
+
+export interface InsightColumns {
+    uid?: string;
+    x?: string;
+    y?: string;
+    z?: string;
+    group?: string;
+    size?: string;
+    color?: string;
+    sort?: string;
+    facet?: string;
+    facetV?: string;
+}

packages/sanddance-specs/src/types.ts

@@ -3,9 +3,8 @@
 * Licensed under the MIT License.
 */
 
-import { Column, Size, View } from '@msrvida/chart-types';
-import { Search } from '@msrvida/search-expression';
-import { Transforms } from 'vega-typings';
+import { Column, Size } from '@msrvida/chart-types';
+import { Insight, InsightColumnRoles } from './insight';
 
 /**
  * Deprecated - use @msrvida/chart-types instead.
@@ -63,70 +62,6 @@ export interface BackgroundImage {
     extents?: Extents;
 }
 
-/**
- * Options to designate a SandDance visualization.
- */
-export interface Insight {
-    backgroundImage?: BackgroundImage;
-    chart: Chart;
-    size: Size;
-    columns: InsightColumns;
-    view?: View;
-    filter?: Search;
-    facetStyle?: FacetStyle;
-    totalStyle?: TotalStyle;
-
-    /**
-     * Type of color binning to use on color scale. Only applicable when the column in the color role is quantitative. 
-     */
-    colorBin?: ColorBin;
-
-    /**
-     * Name of the color scheme. See https://vega.github.io/vega/docs/schemes/
-     */
-    scheme?: string;
-
-    /**
-     * Vega signal values for this insight.
-     */
-    signalValues?: SignalValues;
-
-    /**
-     * Optional flag to hide axes.
-     */
-    hideAxes?: boolean;
-
-    /**
-     * Optional flag to hide legend.
-     */
-    hideLegend?: boolean;
-
-    /**
-     * Optional flag to use CSS colors directly from data.
-     */
-    directColor?: boolean;
-
-    /**
-     * Optional array of Vega transforms to apply to the data.
-     */
-    transform?: Transforms[];
-}
-
-export type InsightColumnRoles = 'uid' | 'x' | 'y' | 'z' | 'group' | 'size' | 'color' | 'facet' | 'facetV' | 'sort';
-
-export interface InsightColumns {
-    uid?: string;
-    x?: string;
-    y?: string;
-    z?: string;
-    group?: string;
-    size?: string;
-    color?: string;
-    sort?: string;
-    facet?: string;
-    facetV?: string;
-}
-
 export interface SpecRoleCapabilities {
     role: InsightColumnRoles;
     excludeCategoric?: boolean;