Skip to content

Conversation

@dmytrostruk
Copy link
Member

Motivation and Context

There is a misalignment between the create/get agent API in the .NET and Python implementations. This PR contains ADR to compare APIs in both languages to decide what needs to be added.

Contribution Checklist

  • The code builds clean without any errors or warnings
  • The PR follows the Contribution Guidelines
  • All unit tests pass, and I have added new tests where possible
  • Is this a breaking change? If yes, add "[BREAKING]" prefix to the title of the PR.

@dmytrostruk dmytrostruk self-assigned this Dec 4, 2025
Copilot AI review requested due to automatic review settings December 4, 2025 03:59
@markwallace-microsoft markwallace-microsoft added the documentation Improvements or additions to documentation label Dec 4, 2025
Copilot finished reviewing on behalf of dmytrostruk December 4, 2025 04:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces an ADR (Architecture Decision Record) that documents the misalignment between .NET and Python implementations of the create/get agent API, proposing a solution to achieve API parity.

  • Documents current API differences between .NET and Python agent creation/retrieval methods
  • Proposes adding missing get_agent and enhanced create_agent methods to Python implementations
  • Provides comprehensive comparison table of current .NET provider implementations

Copy link
Member

@eavanvalkenburg eavanvalkenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can get behind the principle, my only concern is that the overridden create agent methods will need to be async to work and that's not great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants