SqlProjects: Checking mssql.enableExperimentalFeatures for whether to use new dialog (#26454)

* check for shared MSSQL preview config flag

* package.json flags

Author: Benjin

extensions/sql-database-projects/package.json

@@ -386,12 +386,12 @@
         },
         {
           "command": "sqlDatabaseProjects.publish",
-          "when": "view == dataworkspace.views.main && viewItem =~ /^(databaseProject.itemType.project|databaseProject.itemType.legacyProject)$/ && (azdataAvailable || !config.sqlDatabaseProjects.enablePreviewFeatures)",
+          "when": "view == dataworkspace.views.main && viewItem =~ /^(databaseProject.itemType.project|databaseProject.itemType.legacyProject)$/ && (azdataAvailable || !(config.sqlDatabaseProjects.enablePreviewFeatures || config.mssql.enableExperimentalFeatures))",
           "group": "1_dbProjectsFirst@3"
         },
         {
           "command": "sqlDatabaseProjects.publishDialog",
-          "when": "!azdataAvailable && view == dataworkspace.views.main && viewItem =~ /^(databaseProject.itemType.project|databaseProject.itemType.legacyProject)$/ && config.sqlDatabaseProjects.enablePreviewFeatures",
+          "when": "!azdataAvailable && view == dataworkspace.views.main && viewItem =~ /^(databaseProject.itemType.project|databaseProject.itemType.legacyProject)$/ && (config.sqlDatabaseProjects.enablePreviewFeatures || config.mssql.enableExperimentalFeatures)",
           "group": "1_dbProjectsFirst@3"
         },
         {
@@ -633,4 +633,4 @@
     "publisherDisplayName": "Microsoft",
     "publisherId": "Microsoft"
   }
-}
+}

extensions/sql-database-projects/src/common/constants.ts

@@ -680,6 +680,8 @@ export enum PublishTargetType {
 export const CollapseProjectNodesKey = 'collapseProjectNodes';
 export const microsoftBuildSqlVersionKey = 'microsoftBuildSqlVersion';
 export const enablePreviewFeaturesKey = 'enablePreviewFeatures';
+export const mssqlConfigSectionKey = 'mssql';
+export const mssqlEnableExperimentalFeaturesKey = 'enableExperimentalFeatures';
 
 //#endregion
 

extensions/sql-database-projects/src/controllers/projectController.ts

@@ -542,7 +542,10 @@ export class ProjectsController {
 			return publishDatabaseDialog.waitForClose();
 		} else {
 			// If preview feature is enabled, use preview flow
-			const shouldUsePreview = vscode.workspace.getConfiguration(DBProjectConfigurationKey).get(constants.enablePreviewFeaturesKey);
+			const shouldUsePreview =
+				vscode.workspace.getConfiguration(DBProjectConfigurationKey).get<boolean>(constants.enablePreviewFeaturesKey) ||
+				vscode.workspace.getConfiguration(constants.mssqlConfigSectionKey).get<boolean>(constants.mssqlEnableExperimentalFeaturesKey);
+
 			if (shouldUsePreview) {
 				return await vscode.commands.executeCommand(constants.mssqlPublishProjectCommand, project.projectFilePath);
 			} else {