fix(rn-tester): restore RNTesterPods.xcodeproj/project.pbxproj on 0.83-merge#2960
Open
tvinhas wants to merge 1 commit into
Open
fix(rn-tester): restore RNTesterPods.xcodeproj/project.pbxproj on 0.83-merge#2960tvinhas wants to merge 1 commit into
tvinhas wants to merge 1 commit into
Conversation
|
@tvinhas please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This was referenced May 13, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
RNTesterPods.xcodeproj/project.pbxprojfile is missing from0.83-mergebut exists onmain. Without it,pod installfails immediately on0.83-mergewith:[!] The plist file at path /.../packages/rn-tester/RNTesterPods.xcodeproj/project.pbxproj doesn't exist.
Which blocks any contributor from validating any PR against
0.83-mergevia the RNTester pod-install path.Root cause (interaction between an ignore rule and the upstream merge)
Both
mainand0.83-mergecarry this rule in.gitignore:/packages/rn-tester/**/*.xcodeproj
On
main,project.pbxprojis tracked despite that rule —gitignoredoes not affect files already in the index, and the file was originally added before the rule existed (or via-f). On0.83-merge, the file was dropped from thetree at some point during the upstream-0.83 merge (likely via a
git rmresolving a conflicting hunk, or via a merge driver that touched the .xcodeproj contents). Once it was out of the index, the existing ignore rule prevented anyonefrom
git adding it back through the normal path — the explicit-fflag is required.Verification via
gh api:maintree containspackages/rn-tester/RNTesterPods.xcodeproj/project.pbxproj(blob SHA90e6c295ce0ec461333aa96af37d8b0ceebe98dc, 120,346 bytes).0.83-mergetree only containspackages/rn-tester/RNTesterPods.xcodeproj/xcshareddata/(the scheme files).The xcshareddata/ scheme files on
0.83-mergereferenceRNTesterPods.xcodeprojas their container, so the absence isn't an intentional structural change.Fix
This PR restores the file verbatim from
main's blob90e6c295…(force-added past the ignore rule). Once in the index, future operations track it normally. The.gitignorerule is preserved unchanged — it correctly excludes othergenerated
.xcodeprojoutputs and only needed the one-time-fto reseat this specific file.The .pbxproj is structurally cross-compatible between
main(RN 0.81.x content) and0.83-merge(RN 0.83 content) — both branches share the same target layout (RNTester,RNTesterUnitTests,RNTesterIntegrationTests,RNTester-macOS,RNTester-macOSUnitTests,RNTester-macOSIntegrationTests,RNTester-visionOS).pod installregenerates the workspace from this file + the Podfile, so any drift between branches gets reconciled by the install step.If maintainers have a preferred way to regenerate the pbxproj (script, fresh
pod initflow), this PR can be closed in favor of that. The change is offered as the minimal unblock so contributors can resume validation against0.83-merge.Indirectly unblocks the "RNTester validation" item on the Road to 0.83 tracking issue (#2901) — that item can't proceed until pod install works on
0.83-merge.pod installinpackages/rn-testeron0.83-mergefails with[!] The plist file at path .../project.pbxproj doesn't exist.Reproducible on any fresh0.83-mergecheckout.yarn prepare-ioshits the same error insidethe cocoapods-runner subprocess.
pod installinpackages/rn-testeron0.83-mergecompletes withPod installation complete! There are 86 dependencies from the Podfile and 85 total pods installed.RNTesterPods.xcworkspace/contents.xcworkspacedataisgenerated, all
Pods-RNTester*xcconfig files are written, hermes-engine script phases are wired. (Validated locally with HEAD = current0.83-mergetip.)[!] ... CLANG_CXX_LANGUAGE_STANDARD overridewarnings are pre-existing onmainand unrelated to this restore.Related