Skip to content

fix(fmt): patch base.h consteval gate via prepare_command for Xcode 26.x#2961

Open
tvinhas wants to merge 2 commits into
microsoft:0.83-mergefrom
tvinhas:fix-fmt-consteval-xcode-26
Open

fix(fmt): patch base.h consteval gate via prepare_command for Xcode 26.x#2961
tvinhas wants to merge 2 commits into
microsoft:0.83-mergefrom
tvinhas:fix-fmt-consteval-xcode-26

Conversation

@tvinhas
Copy link
Copy Markdown

@tvinhas tvinhas commented May 13, 2026

Summary

Patches fmt 11.0.2's include/fmt/base.h via the podspec's prepare_command to widen the existing "Apple clang < 14 consteval broken" gate so it catches all Apple clang. Xcode 26.x ships a stricter consteval evaluator than fmt 11.0.2
expects; the bundled FMT_STRING macro reaches basic_format_string's consteval constructor and the compiler refuses with:

Pods/fmt/include/fmt/format-inl.h:59:24: error: call to consteval function
'fmt::basic_format_string<...>::basic_format_string<FMT_COMPILE_STRING, 0>'
is not a constant expression

(Multiple sites: lines 59, 60, 1387, 1391, 1394, ...)

This blocks every pod install + xcodebuild cycle on Xcode 26.x for any consumer of react-native-macos — including RNTester-macOS on 0.83-merge and microsoft/react-native-test-app's example-macos.

Why prepare_command (and not xcconfig -D)

An earlier version of this PR set GCC_PREPROCESSOR_DEFINITIONS = "$(inherited) FMT_USE_CONSTEVAL=0" in pod_target_xcconfig. That approach does not actually work: fmt's config chain at base.h:113-132 has no #ifndef FMT_USE_CONSTEVAL guard and unconditionally redefines the macro to 1 on any compiler that sets __cpp_consteval. The -D from the compile command line gets overwritten by the time basic_format_string's decorator is processed.
Verified locally: the macro lands in the generated xcconfig, but compile still fails with the same consteval errors.

Patching the source is the only path that survives clang's preprocessor passes. The existing "Apple clang < 14" branch on base.h:122-123 already disables consteval for compilers fmt's authors consider broken; widening it to catch all
Apple clang versions extends that fix to Xcode 26.x and falls back to fmt's constexpr path, which compiles cleanly. The constexpr path is fmt's documented fallback and is already battle-tested for MSVC < VS2019 16.10, GCC < 10, and Apple
clang < 14.

The sed -i.bak edit:

defined(apple_build_version) && apple_build_version < 14000029L
→ defined(apple_build_version)

Minimal, mechanical, reversible. Long-term fix is a fmt 11.1+ bump (fmt's own upstream addressed this in subsequent releases); this is the workaround until that bump lands.

Test Plan

  • Before: xcodebuild -workspace packages/rn-tester/RNTesterPods.xcworkspace -scheme RNTester-macOS -configuration Debug -destination 'generic/platform=macOS' ARCHS=arm64 build on 0.83-merge fails at CompileC .../fmt.build/.../format.o with the consteval errors above. Reproducible on any Xcode 26.x.
  • After: Same xcodebuild produces ** BUILD SUCCEEDED **. Additionally validated against microsoft/react-native-test-app's example-macos via a local Verdaccio publish: pod install + xcodebuild -scheme Example both green,
    produces a 44 MB ReactTestApp.app linking hermesvm.framework.
  • The patched base.h:122 line on a clean checkout reads #elif defined(__apple_build_version__) (no version constraint), and FMT_USE_CONSTEVAL resolves to 0 for all Apple clang.

Related

The xcconfig GCC_PREPROCESSOR_DEFINITIONS approach doesn't actually work:
fmt's base.h:113-132 chain has no #ifndef guard and unconditionally
redefines FMT_USE_CONSTEVAL=1 on any compiler that sets __cpp_consteval.
Patching base.h via prepare_command is the only path that survives the
preprocessor.
Validated locally on Xcode 26.5: pod install + xcodebuild succeed against
both packages/rn-tester and microsoft/react-native-test-app's example-macos.
@tvinhas tvinhas changed the title fix(fmt): set FMT_USE_CONSTEVAL=0 in fmt.podspec for Xcode 26.x compatibility fix(fmt): patch base.h consteval gate via prepare_command for Xcode 26.x May 13, 2026
@microsoft-github-policy-service
Copy link
Copy Markdown

@tvinhas please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant