Fix stackoverflow in StructInfo #15454
Merged
+15
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for the stack-buffer-overflow when using the FieldInfo like this:
inline winrt::Microsoft::ReactNative::FieldMap GetStructInfo(AppStateSpec_AppState*) noexcept {
winrt::Microsoft::ReactNative::FieldMap fieldMap {
{L"app_state", &AppStateSpec_AppState::app_state},
// ^^^^^^^^^ when constructing the std::pair, temporary stack variables are created.
};
return fieldMap;
}
but here in react-native-windows\vnext\Microsoft.ReactNative.Cxx\StructInfo.h the FieldInfo is trying to dereference and store data from a pointer (&fieldPtr) that points to a temporary object on the stack:
m_fieldPtrStore{*reinterpret_cast<uintptr_t *>(&fieldPtr)}
AddressSanitizer detects the stack-buffer-overflow (accessing memory past the temporary's lifetime) and terminates the process.
Instead, we avoid double indirection by using a memcopy.
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
Author
|
@microsoft-github-policy-service agree company="Meta" |
1 similar comment
Contributor
Author
|
@microsoft-github-policy-service agree company="Meta" |
Contributor
|
/azp run PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vineethkuttan
added
the
AutoMerge
microsoft-github-policy-service
bot
merged commit e990ad5
into
microsoft:main
30 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for the stack-buffer-overflow when using the FieldInfo like this:
but here in react-native-windows\vnext\Microsoft.ReactNative.Cxx\StructInfo.h the FieldInfo is trying to dereference and store data from a pointer (&fieldPtr) that points to a temporary object on the stack:
m_fieldPtrStore{*reinterpret_cast<uintptr_t *>(&fieldPtr)}AddressSanitizer detects the stack-buffer-overflow (accessing memory past the temporary's lifetime) and terminates the process. Instead, we avoid double indirection by using a memcopy.
Microsoft Reviewers: Open in CodeFlow