DTTERM window manipulation shrinks the window even though it requests the current size

[grawity]

Windows Terminal version

1.23.12371.0

Windows build number

10.0.26100.5074

Other Software

OpenSSH_for_Windows_9.5p2
Neovim NVIM v0.11.4 (on Arch Linux)

Steps to reproduce

Maximize the Windows Terminal window.
ssh to some Linux system.
Run nvim (maybe nvim --clean).
Ctrl-Z suspend Nvim and return to the shell.
fg resume Nvim.

Expected Behavior

The terminal window should remain maximized.

Actual Behavior

The terminal window shrinks in height by 1 row every time fg returns to Nvim.

[DHowett]

Alright, I got this under a debug tap. It looks like nvim is trying to restore the window to the size it was in before it was suspended:

I wonder if this is the same root cause as the cluster of issues around #18862 #18582 #18872 (maybe #19265 - if we are doing the math based on the wrong profile) where we receive one of these, calculate the wrong final size, and resize to be slightly smaller than expected.

Three potential fixes. Maybe we should do all of them.

• throw out any OSC 8 ; Ps ; Ps t where both Ps match the current size
  • honestly we should never let this escape the terminal layer; it's a lot of work for a no-op
• allow users to disable window manipulation
• actually fix the bug in the math 😜