-
Notifications
You must be signed in to change notification settings - Fork 114
Open
Description
I tried building from the release tag v0.1.1 like this:
git clone --depth 1 --branch v0.1.1 --recurse-submodules https://github.com/mlc-ai/tokenizers-cpp tokenizers-cpp-0.1.1
cmake -S tokenizers-cpp-0.1.1 -B tokenizers-cpp-0.1.1/build -DCMAKE_BUILD_TYPE=RelWithDebInfo
cmake --build tokenizers-cpp-0.1.1/build
, and the build fails with the error below.
error[E0308]: mismatched types
--> src/lib.rs:78:53
|
78 | let mut tokenizer = Tokenizer::new(BPE::new(vocab, merges));
| -------- ^^^^^ expected `AHashMap<String, u32>`, found `HashMap<String, u32>`
| |
| arguments to this function are incorrect
|
= note: expected struct `ahash::hash_map::AHashMap<std::string::String, u32>`
found struct `HashMap<std::string::String, u32>`
It seems that the submodules referenced in this release tag are not compatible with the source code at the same tag.
The build succeeds at the current main, but building from main is error-prone, so I ended up building from the current commit of main, but I'm not sure if I'm picking up something that is not supposed to be in the v0.1.1 release.
git clone https://github.com/mlc-ai/tokenizers-cpp tokenizers-cpp-0.1.1
cd tokenizers-cpp-0.1.1
git checkout acbdc5a2
git submodule update --init
cd ..
It might be a good idea to move the release tag to the commit that fixed those dependencies.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels