Ensure IsExternalInit is type forwarded on NET builds (#619)

It's included as internal on netstandard/net472, and the C# compiler may bake a reference to that into a consumer. If that consumer is then used with a net8.0+ build, the IsExternalInit needs to be there and forwarded to the real one.

This switches our polyfill files to always be included but the actual contents ifdef'd out on TFMs that already have the contents. That then makes it easier to do specialized ifdef'ing in the future, as this does for IsExternalInit.

Author: stephentoub

src/Common/Polyfills/System/Collections/Generic/CollectionExtensions.cs

@@ -1,3 +1,4 @@
+#if !NET
 using ModelContextProtocol;
 
 namespace System.Collections.Generic;
@@ -18,4 +19,5 @@ public static TValue GetValueOrDefault<TKey, TValue>(this IReadOnlyDictionary<TK
 
     public static Dictionary<TKey, TValue> ToDictionary<TKey, TValue>(this IEnumerable<KeyValuePair<TKey, TValue>> source) =>
         source.ToDictionary(kv => kv.Key, kv => kv.Value);
-}
+}
+#endif

src/Common/Polyfills/System/Diagnostics/CodeAnalysis/DynamicallyAccessedMemberTypes.cs

@@ -1,6 +1,7 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
+#if !NET
 namespace System.Diagnostics.CodeAnalysis;
 
 /// <summary>
@@ -162,3 +163,4 @@ internal enum DynamicallyAccessedMemberTypes
     /// </summary>
     All = ~None
 }
+#endif

src/Common/Polyfills/System/Diagnostics/CodeAnalysis/DynamicallyAccessedMembersAttribute.cs

@@ -1,6 +1,7 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
+#if !NET
 namespace System.Diagnostics.CodeAnalysis;
 
 /// <summary>
@@ -48,3 +49,4 @@ public DynamicallyAccessedMembersAttribute(DynamicallyAccessedMemberTypes member
     /// </summary>
     public DynamicallyAccessedMemberTypes MemberTypes { get; }
 }
+#endif

src/Common/Polyfills/System/Diagnostics/CodeAnalysis/NullableAttributes.cs

@@ -1,6 +1,7 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
+#if !NET
 namespace System.Diagnostics.CodeAnalysis
 {
     /// <summary>Specifies that null is allowed as an input even if the corresponding type disallows it.</summary>
@@ -137,3 +138,4 @@ public MemberNotNullWhenAttribute(bool returnValue, params string[] members)
         public string[] Members { get; }
     }
 }
+#endif

src/Common/Polyfills/System/Diagnostics/CodeAnalysis/RequiresDynamicCodeAttribute.cs

@@ -1,6 +1,7 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
+#if !NET
 namespace System.Diagnostics.CodeAnalysis;
 
 /// <summary>
@@ -36,3 +37,4 @@ public RequiresDynamicCodeAttribute(string message)
     /// </summary>
     public string? Url { get; set; }
 }
+#endif

src/Common/Polyfills/System/Diagnostics/CodeAnalysis/RequiresUnreferencedCode.cs

@@ -1,6 +1,7 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
+#if !NET
 namespace System.Diagnostics.CodeAnalysis;
 
 /// <summary>
@@ -37,3 +38,4 @@ public RequiresUnreferencedCodeAttribute(string message)
     /// </summary>
     public string? Url { get; set; }
 }
+#endif

src/Common/Polyfills/System/Diagnostics/CodeAnalysis/SetsRequiredMembersAttribute.cs

@@ -1,5 +1,7 @@
+#if !NET
 namespace System.Diagnostics.CodeAnalysis
 {
     [AttributeUsage(AttributeTargets.Constructor, AllowMultiple = false, Inherited = false)]
     internal sealed class SetsRequiredMembersAttribute : Attribute;
 }
+#endif

src/Common/Polyfills/System/Diagnostics/CodeAnalysis/StringSyntaxAttribute.cs

@@ -1,6 +1,7 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
+#if !NET
 namespace System.Diagnostics.CodeAnalysis;
 
 /// <summary>Specifies the syntax used in a string.</summary>
@@ -65,4 +66,5 @@ public StringSyntaxAttribute(string syntax, params object?[] arguments)
 
     /// <summary>The syntax identifier for strings containing XML.</summary>
     public const string Xml = nameof(Xml);
-}
+}
+#endif

src/Common/Polyfills/System/Diagnostics/CodeAnalysis/UnconditionalSuppressMessageAttribute.cs

@@ -1,6 +1,7 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
+#if !NET
 namespace System.Diagnostics.CodeAnalysis;
 
 /// <summary>
@@ -81,4 +82,5 @@ public UnconditionalSuppressMessageAttribute(string category, string checkId)
     /// Gets or sets the justification for suppressing the code analysis message.
     /// </summary>
     public string? Justification { get; set; }
-}
+}
+#endif

src/Common/Polyfills/System/IO/StreamExtensions.cs

@@ -3,6 +3,7 @@
 using System.Runtime.InteropServices;
 using System.Text;
 
+#if !NET
 namespace System.IO;
 
 internal static class StreamExtensions
@@ -61,4 +62,5 @@ static async ValueTask<int> ReadAsyncCore(Stream stream, Memory<byte> buffer, Ca
             }
         }
     }
-}
+}
+#endif