Skip to content

Conversation

@krisn0x
Copy link
Contributor

@krisn0x krisn0x commented Nov 25, 2025

Summary

Phantombuster's API throws an error if we send argument or bonusArgument as empty objects, which happened if the user didn't provide any values for those. This fix adds validation to ensure we omit the objects entirely if they are empty.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-4002/community-issue-phantombuster-node-not-filled-in-optional-fields-are
fixes #18087

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Nov 25, 2025
@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@currents-bot
Copy link

currents-bot bot commented Nov 25, 2025

E2E Tests: n8n tests passed after 9m 21.5s

🟢 576 · 🔴 0 · ⚪️ 43 · 🟣 2

View Run Details

Run Details

  • Project: n8n

  • Groups: 2

  • Framework: Playwright

  • Run Status: Passed

  • Commit: 58d33e8

  • Spec files: 129

  • Overall tests: 619

  • Duration: 9m 21.5s

  • Parallelization: 9

Groups

GroupId Results Spec Files Progress
multi-main:ui 🟢 519 · 🔴 0 · ⚪️ 43 · 🟣 2 120 / 120
multi-main:ui:isolated 🟢 57 · 🔴 0 · ⚪️ 0 9 / 9


This message was posted automatically by currents.dev | Integration Settings

Copy link
Contributor

@RomanDavydchuk RomanDavydchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix works as expected and code looks good 🙌

Also good job on the tests, just left one small nitpick (not required to address it, only if you want to)

But I noticed that your commits are unverified, i.e. without signature, I think it's required for us to have the commit signature set up, so I think you'd need to configure it and repush your changes 😓 But once that is done, we can merge it

@blacksmith-sh

This comment has been minimized.

Copy link
Contributor

@RomanDavydchuk RomanDavydchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, great that you fixed the signature as well. One last comment and we can merge it 🙌

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this workflow file can be removed since it's no longer used in tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

n8n team Authored by the n8n team node/improvement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PhantomBuster node - Not filled in optional fields are sent to Phantoms as empty argument

3 participants