Update NC fails if PreviewGenerator app is disabled#2117
Merged
Conversation
…riable Signed-off-by: MagelanM <magellanm@posteo.de>
Collaborator
|
Oh wow, thanks for that. That's a big oversight on my side. |
Author
|
So it will fix issue #2119 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
During the update from NC 33.0.2 to NC 33.0.3 using ncp (ncp-config), the update kept failing without any apparent error message.
I had installed PreviewGenerator on my instance but had not activated it.
Workaround: If PreviewGenerator is installed before the update, the error does not occur.
Details
In etc/library.sh the function is_app_enabled() ignores its argument and always checks for previewgenerator instead of the app passed as $1. This causes is_app_enabled notify_push to return the wrong result depending on whether previewgenerator is enabled, leading nc-update-nextcloud to attempt app:install notify_push even when it is already installed — which fails and triggers a rollback due to set -eE.
Debug information