-
Notifications
You must be signed in to change notification settings - Fork 61
Description
Is there an existing issue for this?
- I have searched the existing issues
Have you installed the latest development version of the package(s) in question?
- I have installed the latest development version of the package.
If this is a data issue, have you tried clearing your nflverse cache?
I have cleared my nflverse cache and the issue persists.
What version of the package do you have?
5.1.0.9002
Describe the bug
After the MUFFED FG in the New Orleans and Carolina game, a new drive should begin.
Here is the drive info from the NFL (Start, End, Length, Obtained, Start Posn, Plays, Yards, Pen, Net Yds, 1rst D, End Posn, Drive Result) for the two drives in question. Note how one drive ends at 6:29 and the next drive begins at the same time, 6:29.
12:50, 06:29, 6:21, Punt, CAR 10, 11, 60, 0, 60, 3, NO 30, Missed FG
06:29, 04:30, 1:59, Muffed FG, NO 30, 4, 11, 0, 11, 1, NO 15, Fumble
Reprex
pbp_data %>% filter(game_id == "2025_10_NO_CAR") %>% select(fixed_drive, play_id, desc)Expected Behavior
fixed_drive should increment up at the start of the new drive following the muffed fg. The game officially had 19 drives, not 18. It seems more appropriate to count them this way, since one drive ended on a field goal attempt, and the other drive is a failed drive that began on a short field (they didn't even get to retry the FG attempt because they turned the ball over!).
nflverse_sitrep
── System Info ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
• R version 4.4.1 (2024-06-14 ucrt) • Running under: Windows 10 x64 (build 19045)
── Package Status ────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
package installed cran dev behind
1 nfl4th 1.0.4 1.0.4 1.0.4.9005 dev
2 nflfastR 5.1.0.9002 5.1.0 5.1.0.9002
3 nflplotR 1.4.0 1.4.0 1.4.0.9003 dev
4 nflreadr 1.4.1 1.5.0 1.5.0 cran;dev
5 nflseedR 1.2.0 2.0.1 2.0.1 cran;dev
6 nflverse 1.0.3 1.0.3 1.0.3.9001 dev
── Package Options ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
• No options set for above packages
── Package Dependencies ──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
• askpass (1.2.0) • htmlwidgets (1.6.4) • snakecase (0.11.1)
• backports (1.5.0) • httr (1.4.7) • stringi (1.8.4)
• base64enc (0.1-3) • isoband (0.2.7) • stringr (1.5.1)
• bigD (0.2.0) • janitor (2.2.0) • sys (3.4.2)
• bitops (1.0-8) • jquerylib (0.1.4) • tibble (3.2.1)
• bslib (0.8.0) • jsonlite (1.8.9) • tidyr (1.3.1)
• cachem (1.1.0) • juicyjuice (0.1.0) • tidyselect (1.2.1)
• cli (3.6.3) • knitr (1.48) • timechange (0.3.0)
• colorspace (2.1-1) • labeling (0.4.3) • tinytex (0.53)
• commonmark (1.9.1) • lifecycle (1.0.4) • utf8 (1.2.4)
• cpp11 (0.5.0) • listenv (0.9.1) • V8 (5.0.1)
• crayon (1.5.3) • lubridate (1.9.3) • vctrs (0.6.5)
• curl (5.2.3) • magick (2.8.5) • viridisLite (0.4.2)
• data.table (1.16.0) • magrittr (2.0.3) • withr (3.0.1)
• digest (0.6.37) • markdown (1.13) • xfun (0.47)
• dplyr (1.1.4) • memoise (2.0.1) • xgboost (1.7.8.1)
• evaluate (1.0.0) • mime (0.12) • xml2 (1.3.6)
• fansi (1.0.6) • munsell (0.5.1) • yaml (2.3.10)
• farver (2.1.2) • openssl (2.2.2) • codetools (0.2-20)
• fastmap (1.2.0) • parallelly (1.38.0) • compiler (4.4.1)
• fastrmodels (2.0.0) • pillar (1.9.0) • graphics (4.4.1)
• fontawesome (0.5.2) • pkgconfig (2.0.3) • grDevices (4.4.1)
• fs (1.6.4) • progressr (0.14.0) • grid (4.4.1)
• furrr (0.3.1) • proto (1.0.0) • lattice (0.22-6)
• future (1.34.0) • purrr (1.0.2) • MASS (7.3-60.2)
• generics (0.1.3) • R6 (2.5.1) • Matrix (1.7-0)
• ggpath (1.0.2) • rappdirs (0.3.3) • methods (4.4.1)
• ggplot2 (3.5.1) • RColorBrewer (1.1-3) • mgcv (1.9-1)
• globals (0.16.3) • Rcpp (1.0.13) • nlme (3.1-164)
• glue (1.7.0) • reactable (0.4.4) • parallel (4.4.1)
• gsubfn (0.7) • reactR (0.6.1) • splines (4.4.1)
• gt (1.0.0) • rlang (1.1.4) • stats (4.4.1)
• gtable (0.3.5) • rmarkdown (2.28) • tools (4.4.1)
• highr (0.11) • rstudioapi (0.16.0) • utils (4.4.1)
• hms (1.1.3) • sass (0.4.9)
• htmltools (0.5.8.1) • scales (1.3.0)
──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────Screenshots
Additional context
Thanks so much for this very fun and useful tool!