Skip to content

Commit 63ff92e

Browse files
committed
Updated docs removing SNI warnings
1 parent 7365378 commit 63ff92e

File tree

3 files changed

+0
-13
lines changed

3 files changed

+0
-13
lines changed

app/mbedtls/app/espconn_secure.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,6 @@ sint8 espconn_secure_send(struct espconn *espconn, uint8 *psent, uint16 length)
184184
bool ICACHE_FLASH_ATTR
185185
espconn_secure_set_hostname(const char* hostname)
186186
{
187-
printf("Setting SNI hostname: %s\n", hostname ? hostname : "NULL");
188187

189188
if (ssl_client_options.hostname) {
190189
os_free(ssl_client_options.hostname);
@@ -195,7 +194,6 @@ espconn_secure_set_hostname(const char* hostname)
195194
ssl_client_options.hostname = (char*)os_malloc(strlen(hostname) + 1);
196195
if (ssl_client_options.hostname) {
197196
strcpy(ssl_client_options.hostname, hostname);
198-
printf("SNI hostname set successfully: %s\n", ssl_client_options.hostname);
199197
return true;
200198
}
201199
return false;

app/modules/tls.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,6 @@ static int tls_socket_connect( lua_State *L ) {
204204
ud->pesp_conn.state = ESPCONN_NONE;
205205
ud->pesp_conn.proto.tcp->remote_port = port;
206206

207-
espconn_secure_set_hostname(domain);
208207
espconn_regist_connectcb(&ud->pesp_conn, (espconn_connect_callback)tls_socket_onconnect);
209208
espconn_regist_disconcb(&ud->pesp_conn, (espconn_connect_callback)tls_socket_ondisconnect);
210209
espconn_regist_reconcb(&ud->pesp_conn, (espconn_reconnect_callback)tls_socket_onreconnect);

docs/modules/tls.md

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -41,16 +41,6 @@ most common features supported. Specifically, it provides:
4141
[socat](http://www.dest-unreach.org/socat/) program is one possible
4242
mechanism of achieving such a "bent pipe" with TLS on both halves.
4343

44-
!!! warning
45-
46-
The TLS glue provided by Espressif provides no interface to TLS SNI.
47-
As such, NodeMCU TLS should not be expected to function with endpoints
48-
requiring the use of SNI, which is a growing fraction of the Internet
49-
and includes, for example, Cloudflare sites using their "universal SSL"
50-
service and other, similar "virtual" TLS servers. TLS servers to which
51-
you wish NodeMCU to connect should have their own, dedicated IP/port
52-
pair.
53-
5444
!!! warning
5545

5646
The TLS handshake is very heap intensive, requiring between 25 and 30

0 commit comments

Comments
 (0)