Skip to content

Commit c8faff2

Browse files
committed
Disable Windows jobs
1 parent 0a64183 commit c8faff2

File tree

1 file changed

+86
-83
lines changed

1 file changed

+86
-83
lines changed

.github/workflows/build.yml

Lines changed: 86 additions & 83 deletions
Original file line numberDiff line numberDiff line change
@@ -55,29 +55,32 @@ jobs:
5555
name: luac.cross_${{ matrix.lua_ver }}_${{ matrix.numbers }}
5656
path: luac.cross
5757

58-
59-
build_luac_cross_win:
60-
61-
runs-on: windows-2019
62-
63-
steps:
64-
- uses: actions/checkout@v4
65-
with:
66-
submodules: true
67-
- name: Build luac.cross.exe
68-
run: |
69-
set
70-
"%programfiles%\git\usr\bin\xargs"
71-
cd msvc
72-
"%programfiles(x86)%\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\Bin\msbuild.exe" /p:Configuration=Release /p:Platform=x64
73-
mv luac-cross/x64/Release/luac.cross.exe ..
74-
shell: cmd
75-
- name: Upload luac.cross
76-
if: ${{ success() }}
77-
uses: actions/upload-artifact@v4
78-
with:
79-
name: luac.cross_51_float_win
80-
path: luac.cross.exe
58+
# The files in the 'msvc' folder would need to be updated to be compatible with VS 2022.
59+
# Sample job (that failed): https://github.com/nodemcu/nodemcu-firmware/actions/runs/17306868602/job/49131917376#step:3:153
60+
# => disable the Windows jobs for now
61+
62+
# build_luac_cross_win:
63+
64+
# runs-on: windows-2022
65+
66+
# steps:
67+
# - uses: actions/checkout@v4
68+
# with:
69+
# submodules: true
70+
# - name: Build luac.cross.exe
71+
# run: |
72+
# set
73+
# "C:\msys64\usr\bin\xargs.exe"
74+
# cd msvc
75+
# "%programfiles%\Microsoft Visual Studio\2022\Enterprise\MSBuild\Current\Bin\MSBuild.exe" /p:Configuration=Release /p:Platform=x64
76+
# mv luac-cross/x64/Release/luac.cross.exe ..
77+
# shell: cmd
78+
# - name: Upload luac.cross
79+
# if: ${{ success() }}
80+
# uses: actions/upload-artifact@v4
81+
# with:
82+
# name: luac.cross_51_float_win
83+
# path: luac.cross.exe
8184

8285

8386
compile_lua:
@@ -117,33 +120,33 @@ jobs:
117120
shell: bash
118121

119122

120-
compile_lua_win:
121-
122-
strategy:
123-
fail-fast: false
124-
matrix:
125-
lua_ver: [51]
126-
numbers: ['float']
127-
filter: [ 'cat' ]
128-
needs: build_luac_cross_win
129-
runs-on: windows-latest
130-
131-
steps:
132-
- name: Checkout repo
133-
uses: actions/checkout@v4
134-
with:
135-
submodules: false
136-
- name: Download luac.cross
137-
uses: actions/download-artifact@v4
138-
with:
139-
name: luac.cross_${{ matrix.lua_ver }}_${{ matrix.numbers }}_win
140-
path: ./
141-
- name: compile Lua
142-
run: |
143-
PATH="/C/Program\ Files/Git/usr/bin:${PATH}"
144-
find lua_modules lua_examples tests/NTest* -iname "*.lua" | ${{ matrix.filter }} | xargs --delimiter="\n" echo
145-
find lua_modules lua_examples tests/NTest* -iname "*.lua" | ${{ matrix.filter }} | xargs --delimiter="\n" ./luac.cross -p
146-
shell: bash
123+
# compile_lua_win:
124+
125+
# strategy:
126+
# fail-fast: false
127+
# matrix:
128+
# lua_ver: [51]
129+
# numbers: ['float']
130+
# filter: [ 'cat' ]
131+
# needs: build_luac_cross_win
132+
# runs-on: windows-latest
133+
134+
# steps:
135+
# - name: Checkout repo
136+
# uses: actions/checkout@v4
137+
# with:
138+
# submodules: false
139+
# - name: Download luac.cross
140+
# uses: actions/download-artifact@v4
141+
# with:
142+
# name: luac.cross_${{ matrix.lua_ver }}_${{ matrix.numbers }}_win
143+
# path: ./
144+
# - name: compile Lua
145+
# run: |
146+
# PATH="/C/Program\ Files/Git/usr/bin:${PATH}"
147+
# find lua_modules lua_examples tests/NTest* -iname "*.lua" | ${{ matrix.filter }} | xargs --delimiter="\n" echo
148+
# find lua_modules lua_examples tests/NTest* -iname "*.lua" | ${{ matrix.filter }} | xargs --delimiter="\n" ./luac.cross -p
149+
# shell: bash
147150

148151

149152
NTest:
@@ -188,39 +191,39 @@ jobs:
188191
shell: bash
189192

190193

191-
NTest_win:
192-
193-
strategy:
194-
fail-fast: false
195-
matrix:
196-
lua_ver: [51]
197-
numbers: ['float']
198-
needs: build_luac_cross_win
199-
runs-on: windows-latest
200-
201-
steps:
202-
- name: Checkout repo
203-
uses: actions/checkout@v4
204-
with:
205-
submodules: false
206-
- name: Download luac.cross
207-
uses: actions/download-artifact@v4
208-
with:
209-
name: luac.cross_${{ matrix.lua_ver }}_${{ matrix.numbers }}_win
210-
path: ./
211-
- name: NTest selfcheck
212-
run: |
213-
cd tests/NTest
214-
../../luac.cross.exe -e ../NTest/NTest_NTest.lua | tee log
215-
grep "failed. 0" log
216-
shell: bash
217-
- name: NTest hosttests
218-
run: |
219-
cd tests
220-
cp NTest/NTest.lua .
221-
../luac.cross.exe -e NTest_lua.lua | tee log
222-
(if grep " ==> " log ; then exit 1 ; fi)
223-
shell: bash
194+
# NTest_win:
195+
196+
# strategy:
197+
# fail-fast: false
198+
# matrix:
199+
# lua_ver: [51]
200+
# numbers: ['float']
201+
# needs: build_luac_cross_win
202+
# runs-on: windows-latest
203+
204+
# steps:
205+
# - name: Checkout repo
206+
# uses: actions/checkout@v4
207+
# with:
208+
# submodules: false
209+
# - name: Download luac.cross
210+
# uses: actions/download-artifact@v4
211+
# with:
212+
# name: luac.cross_${{ matrix.lua_ver }}_${{ matrix.numbers }}_win
213+
# path: ./
214+
# - name: NTest selfcheck
215+
# run: |
216+
# cd tests/NTest
217+
# ../../luac.cross.exe -e ../NTest/NTest_NTest.lua | tee log
218+
# grep "failed. 0" log
219+
# shell: bash
220+
# - name: NTest hosttests
221+
# run: |
222+
# cd tests
223+
# cp NTest/NTest.lua .
224+
# ../luac.cross.exe -e NTest_lua.lua | tee log
225+
# (if grep " ==> " log ; then exit 1 ; fi)
226+
# shell: bash
224227

225228

226229
luacheck:

0 commit comments

Comments
 (0)