Skip to content

Commit 04843dc

Browse files
committed
add TODO to show that I don't understand the ellision feature
For example, with `(match? [#{2}] [#{1 2}])` it currently gives `[#{(unexpected 1)} ...]` This feels misleading to me because there aren't more elements in the vector that are being elided. It should be more like `[#{(unexpected 1) ...}]` or at worst something like `[#{(unexpected 1) ...} ...]`
1 parent 3e0d13f commit 04843dc

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

test/clj/matcher_combinators/config_test.clj

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,9 @@
5555
(c/match [#{2}] [#{1 2}])))))
5656

5757
(config/enable-abbreviation!)
58+
;; TODO PLM: `[#{(unexpected 1)} ...]` feels not completely correct.
59+
;; shouldn't it be `[#{(unexpected 1) ...}]` or `[#{(unexpected 1)} ...]`
60+
;; instead?
5861
(is (= (str "[#{(unexpected " (colorize/red 1) ")} ...]\n")
5962
(printer/as-string
6063
(:matcher-combinators.result/value

0 commit comments

Comments
 (0)