Skip to content

[Types] Wrong recursion in Mark’s _tip_ option #2459

Description

@mwaibel-go

MarkOption.tip is of type TipOptions. (This is a simplified statement, but true enough for this issue description).

TipOptions itself derives from MarkOptions.

This recursion lets us specify nested tips:

Plot.dot(penguins, {x: "culmen_length_mm", y: "culmen_depth_mm", tip: {tip: {tip: {tip: {tip: {tip: {}}}}}}}).plot()

TipOptions should probably exclude the tip property.

Related: #2423

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn’t working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions