[IMP] estate: Apply constrain to form fields

Added a constraint on the expected price and the selling price
so that they can't be negative

Applied a constraint on the offer's price so that it can't be negative

Added a unique name check for tags and types model

Chapter 10

Author: shsak-odoo

estate/models/estate_property.py

@@ -1,4 +1,5 @@
 from odoo import models, fields, api, exceptions
+from odoo.tools.float_utils import float_compare
 
 
 class EstateProperty(models.Model):
@@ -74,3 +75,21 @@ def set_property_sold(self):
             else:
                 record.state = 'sold'
         return True
+
+    _check_expected_price = models.Constraint(
+        'CHECK(expected_price > 0)',
+        'The Expected price cannot be 0 or less then 0'
+    )
+
+    _check_selling_price = models.Constraint(
+        'CHECK(selling_price >= 0)',
+        'The Selling price cannot be less then 0'
+    )
+
+    @api.constrains('selling_price', 'buyer', 'expected_price')
+    def _check_selling_price_90p(self):
+        for record in self:
+            if record.selling_price == 0:
+                return False
+            if float_compare((record.selling_price/record.expected_price) * 100, 90, precision_digits=2) < 0:
+                raise exceptions.ValidationError('Selling Price should be 90% or more of expected price.')

estate/models/estate_property_offer.py

@@ -16,7 +16,7 @@ class EstatePropertyOffer(models.Model):
     validity = fields.Integer(default=7)
     date_deadline = fields.Date(compute='_compute_offer_date_deadline', inverse='_inverse_offer_date_deadline')
 
-    @api.depends('create_date', 'validity')
+    @api.depends('validity')
     def _compute_offer_date_deadline(self):
         for record in self:
             if record.create_date:
@@ -30,8 +30,6 @@ def _inverse_offer_date_deadline(self):
 
     def action_offer_accepted(self):
         for record in self:
-            if record.status == 'accepted':
-                return False
             if record.property_id.buyer:
                 raise exceptions.UserError('An another offer is already accepted')
             record.property_id.selling_price = record.price
@@ -43,3 +41,8 @@ def action_offer_refused(self):
         for record in self:
             record.status = 'refused'
         return True
+
+    _check_offer_price = models.Constraint(
+        'CHECK(price > 0)',
+        'Offer Price cannot be 0 or below 0'
+    )

estate/models/estate_property_tag.py

@@ -2,7 +2,12 @@
 
 
 class EstatePropertyTag(models.Model):
-    _name = "estate.property.tag"
-    _description = "Tag for the property"
+    _name = 'estate.property.tag'
+    _description = 'Tag for the property'
 
     name = fields.Char(required=True)
+
+    _check_unique_name = models.Constraint(
+        'unique(name)',
+        'A tag with the same name already exists.'
+    )

estate/models/estate_property_type.py

@@ -2,7 +2,12 @@
 
 
 class EstatePropertyType(models.Model):
-    _name = "estate.property.type"
-    _description = "Defines the type of Real Estate Property"
+    _name = 'estate.property.type'
+    _description = 'Defines the type of Real Estate Property'
 
     name = fields.Char(required=True)
+
+    _check_unique_name = models.Constraint(
+        'unique(name)',
+        'A tag with the same name already exists.'
+    )

estate/views/estate_property_views.xml

@@ -4,12 +4,10 @@
         <field name="model">estate_property</field>
         <field name="arch" type="xml">
             <form string="Description">
-                <haeder>
-                    <group col="2">
-                        <button type="object" name="cancel_property_sale" string="Cancel" />
-                        <button type="object" name="set_property_sold" string="Sold" />
-                    </group>
-                </haeder>
+                <header>
+                    <button type="object" name="cancel_property_sale" string="Cancel" />
+                    <button type="object" name="set_property_sold" string="Sold" />
+                </header>
                 <sheet>
                     <h1>
                         <field name="name" nolabel="True" />
@@ -100,4 +98,4 @@
         <field name="res_model">estate_property</field>
         <field name="view_mode">list,form</field>
     </record>
-</odoo>
+</odoo>