Skip to content

Conversation

@legendecas
Copy link
Member

Which problem is this PR solving?

In preparation for the erasableSyntaxOnly option and Node.js type stripping feature, disallow the constructor parameter property syntax as it is not supported in either of these two conditions.

Type of change

  • Internal house keeping.

This should not introducing any observable differences.

Checklist:

  • Followed the style guidelines of this project

@legendecas legendecas requested a review from a team as a code owner December 4, 2025 15:27
@codecov
Copy link

codecov bot commented Dec 6, 2025

Codecov Report

❌ Patch coverage is 99.39024% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.42%. Comparing base (4246776) to head (bb81d30).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...sdk-metrics/src/aggregator/ExponentialHistogram.ts 96.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6187      +/-   ##
==========================================
+ Coverage   95.40%   95.42%   +0.01%     
==========================================
  Files         317      317              
  Lines        9462     9523      +61     
  Branches     2199     2197       -2     
==========================================
+ Hits         9027     9087      +60     
- Misses        435      436       +1     
Files with missing lines Coverage Δ
api/src/trace/NonRecordingSpan.ts 95.83% <100.00%> (+0.18%) ⬆️
api/src/trace/ProxyTracer.ts 100.00% <100.00%> (ø)
experimental/packages/api-logs/src/ProxyLogger.ts 88.23% <100.00%> (+0.73%) ⬆️
...ackages/otlp-exporter-base/src/OTLPExporterBase.ts 100.00% <100.00%> (ø)
...ges/otlp-exporter-base/src/otlp-export-delegate.ts 100.00% <100.00%> (ø)
...kages/otlp-exporter-base/src/retrying-transport.ts 93.93% <100.00%> (+0.18%) ⬆️
...rter-base/src/transport/http-exporter-transport.ts 96.15% <100.00%> (+0.15%) ⬆️
...-grpc-exporter-base/src/grpc-exporter-transport.ts 100.00% <100.00%> (ø)
...mental/packages/sampler-composite/src/composite.ts 92.85% <100.00%> (+0.17%) ⬆️
.../packages/sampler-composite/src/parentthreshold.ts 81.81% <100.00%> (+0.86%) ⬆️
... and 32 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants