Skip to content

Conversation

@pichlermarc
Copy link
Member

Which problem is this PR solving?

See #6188 - @opentelemetry/context-async-hooks is used as a dependency but is only in devDependencies. It should still be pulled in by @opentelemetry/sdk-trace-node though.

Fixes #6188

@pichlermarc pichlermarc force-pushed the fix/node-sdk-missing-dep branch from c0dc3ef to 3ebeb70 Compare December 5, 2025 09:45
@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.40%. Comparing base (bc9e37f) to head (941ae12).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6189   +/-   ##
=======================================
  Coverage   95.40%   95.40%           
=======================================
  Files         317      317           
  Lines        9462     9462           
  Branches     2199     2199           
=======================================
  Hits         9027     9027           
  Misses        435      435           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pichlermarc pichlermarc marked this pull request as ready for review December 6, 2025 18:10
@pichlermarc pichlermarc requested a review from a team as a code owner December 6, 2025 18:10
@pichlermarc pichlermarc added bug Something isn't working priority:p3 Bugs which cause problems in user apps not related to correctness (performance, memory use, etc) pkg:sdk-node labels Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working pkg:sdk-node priority:p3 Bugs which cause problems in user apps not related to correctness (performance, memory use, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Node SDK declares @opentelemetry/context-async-hooks as a dev dependency instead of a dependency

3 participants