fix(instrumentation-fetch): handle HeadersInit tuple arrays correctly #6194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The _addHeaders method did not properly handle HeadersInit when passed as an array of tuples (e.g., [["Content-Type", "application/json"]]). The code fell through to an else branch using Object.assign(), which corrupted the headers into an object with numeric keys. This fix simplifies the logic by using `new Headers()` which correctly handles all valid HeadersInit types: undefined, Headers, Record<string, string>, and Iterable<[string, string]>. Also updates existing test to use Headers.set() API since headers are now always normalized to Headers objects. Signed-off-by: Ibu Madha <[email protected]>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
When
HeadersInitis passed as an array of tuples (e.g.,[["Content-Type", "application/json"]]), the_addHeadersmethod falls through to an else branch that usesObject.assign(). This corrupts the headers into an object with numeric keys like{"0": "Content-Type", "1": "application/json"}.Short description of the changes
Simplifies the logic by using
new Headers()which correctly handles all validHeadersInittypes:undefined/nullHeadersobjectRecord<string, string>Iterable<[string, string]>(including array of tuples)Also updates an existing test to use
Headers.set()API since headers are now normalized toHeadersobjects.Type of change
How Has This Been Tested?