Extend setup wizard timeout for Teams channel setup#648
Conversation
Use a shared setup wizard timeout classifier for both the UI-hosted and setup-engine wizard flows. Slow channel/plugin install and download steps now get the same extended timeout already used for auth/device-code flows, including when the selected option text contains Teams. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Codex review: needs maintainer review before merge. Reviewed June 7, 2026, 9:06 PM ET / 01:06 UTC. Summary Reproducibility: no. live high-confidence reproduction was run. Source inspection on current master shows both wizard.next callers keep generic channel/plugin/Teams steps on the short timeout path, matching the linked report's failure shape. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Merge this PR, or an equivalent narrow fix, after maintainer review and required checks confirm slow Teams/channel/plugin wizard steps get the longer timeout while ordinary questions keep the default timeout. Do we have a high-confidence way to reproduce the issue? No live high-confidence reproduction was run. Source inspection on current master shows both wizard.next callers keep generic channel/plugin/Teams steps on the short timeout path, matching the linked report's failure shape. Is this the best way to solve the issue? Yes. The PR is a narrow maintainable fix because it removes duplicated timeout heuristics, feeds selected-answer context into both runners, and adds targeted regression tests without changing gateway protocol or setup state storage. AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against d1b136347e95. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Thanks for this PR. I rebased/resolved the current conflict and added a small regression fix/test for headless multiselect answers with opaque option values whose label/hint is Teams/channel-related. Could you please do one extra manual smoke on your side before we merge: run the setup wizard through the Teams/channel setup path that originally timed out, ideally including a slow plugin/install/download step, and confirm the step now survives beyond the previous 30s timeout without regressing ordinary short wizard questions? Local build/tests and adversarial review are clean on the updated branch. |
Summary
Validation
OPENCLAW_REPO_ROOT=C:\oc641 .\build.ps1dotnet test .\tests\OpenClaw.SetupEngine.Tests\OpenClaw.SetupEngine.Tests.csproj --no-restoredotnet test .\tests\OpenClaw.Shared.Tests\OpenClaw.Shared.Tests.csproj --no-restoredotnet test .\tests\OpenClaw.Tray.Tests\OpenClaw.Tray.Tests.csproj --no-restoreNote: running
build.ps1from the full generated worktree path hit a WinAppSDK PRI expansion path failure forCommunityToolkit.WinUI.Controls.SettingsControls.pri.xml. The same baseline build passed from the main checkout, and the worktree validation passed via a shortC:\oc641junction to the same branch contents.Fixes: #641