fix(eval): preserve traces and reasoning controls - #45
Conversation
|
Codex review: needs maintainer review before merge. Reviewed July 28, 2026, 11:16 AM ET / 15:16 UTC. ClawSweeper reviewWhat this changesThis PR expands ShellBench’s native evaluation runner to export OpenClaw and Hermes trajectories, independently route judge reasoning, avoid OpenClaw bootstrap contamination, and recover/finish remote runs more reliably. Merge readinessKeep this draft open for maintainer review rather than cleanup closure: it is a member-authored, stacked native-evaluation change with a viable implementation direction but outstanding integrated validation. Likely related people: vincentkoc is the strongest routing candidate from the current native-evaluation commit series and prerequisite stack. Priority: P2 Review scores
Verification
How this fits togetherShellBench’s native-evaluation pipeline plans model runs, starts remote harnesses through the fleet controller, gathers native session output, converts it into comparable trajectories, and aggregates scored results. This PR changes the runner and proxy layers that determine whether benchmark outputs are complete, correctly attributed, and safe to compare. flowchart LR
A[Evaluation plan] --> B[Proxy model routes]
B --> C[Remote fleet controller]
C --> D[OpenClaw or Hermes harness]
D --> E[Native logs and sessions]
E --> F[Trajectory conversion]
F --> G[Aggregation and leaderboard]
C --> H[Checkpoint and final archives]
Decision needed
Why: The correct merge boundary determines benchmark comparability and remote-run operational risk; isolated unit coverage does not settle the behavior of the stacked fleet, proxy, harness, archive, and aggregation path. Before merge
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Merge the prerequisite stack in order, rebase this branch onto its landed base, then attach a redacted completed-matrix and lifecycle artifact audit that proves trace completeness, fixed judge effort, clean agent termination, and preserved archive access together. Do we have a high-confidence way to reproduce the issue? Not applicable as an issue reproduction: this PR reports live AWS, proxy, and lifecycle probes for several changed paths, but its corrected full matrix audit is still pending. Is this the best way to solve the issue? Unclear: the individual repairs and focused coverage are coherent, but the broad stacked implementation is only the best landing path once maintainers accept the combined benchmark semantics and integrated operational proof. AGENTS.md: unclear because the file could not be read completely. Codex review notes: model internal, reasoning high; reviewed against 28ce18e5dfc8. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (10 earlier review cycles; latest 8 shown)
|
|
Superseded by #46, which replayed and landed this branch’s still-unmerged commits after the parent squash made the protected stack impossible to update in place. |
What does this PR do?
Preserves complete native OpenClaw, Hermes, and Codex traces, converts them to Harbor-compatible ATIF-v1.7 trajectories, and makes agent, judge, repair, and post-processing provenance independently auditable.
Why?
The first GPT-5.6 OpenClaw/Hermes matrix completed all tasks, but native trajectory export was incomplete. A later behavioral audit found that baseline
BOOTSTRAP.mdsetup could push OpenClaw into onboarding instead of task execution. Codex also exposed a trace collector edge case when binary tool output corrupted the CLI JSONL stream even though the native session rollout remained complete.The final audit then found two post-processing defects: verifier
scorecard.jsoninfra statuses were not included in repair planning, and aggregate task names trusted display titles instead of canonicaltask_id.pathleaves.Changes
xhighreasoning effort while keeping the judge pinned independently at highskipBootstrap, removeBOOTSTRAP.md, and detect markerless final envelopestask_id.pathValidation
PYTHONPATH=. pytest -q tests/test_native_eval*.py(395 passed, 5 skipped on the full runner series)f2633f26c35958b3aacd15702712a60318ad624bshellbench-judgestays at highResult publications