CORENET-7134: Add ovn-kubernetes toolset skeleton by mattedallo · Pull Request #315 · openshift/openshift-mcp-server

mattedallo · 2026-05-19T15:23:15Z

Summary

Registers a new ovn-kubernetes toolset as scaffolding for OVN-Kubernetes networking diagnostics integration (enhancements#2002).

Adds pkg/toolsets/ovnkubernetes/toolset.go — empty toolset implementing api.Toolset, registered via init()
Adds blank import in pkg/mcp/modules.go
Adds ovn-kubernetes to the TestGranularToolsetsTools snapshot test with an empty [] snapshot

The toolset ships with zero tools — sibling stories CORENET-7135 (OVS tools) and CORENET-7136 (OVN tools) will add tool handlers on top of this framework.

Verification

make build — binary compiles with the new toolset
make test — all tests pass (including the new snapshot test)
make lint — no lint violations

What is NOT in this PR

No tool implementations (deferred to CORENET-7135/7136/7137/7138)
No ovn-kubernetes-mcp Go dependency (arrives with tool implementations)
No execution adapter / pod-exec changes (depends on CORENET-7133)
No README/docs update (zero tools means empty generated sections)

Summary by CodeRabbit

Release Notes

New Features
- Introduced OVN-Kubernetes CNI network troubleshooting toolset, providing dedicated network diagnostic and troubleshooting capabilities for OVN-Kubernetes environments.
Tests
- Extended test coverage to include validation of the new OVN-Kubernetes toolset and its associated network troubleshooting tools.

openshift-ci-robot · 2026-05-19T15:23:21Z

@mattedallo: This pull request references CORENET-7134 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Registers a new ovn-kubernetes toolset as scaffolding for OVN-Kubernetes networking diagnostics integration (enhancements#2002).

Adds pkg/toolsets/ovnkubernetes/toolset.go — empty toolset implementing api.Toolset, registered via init()

Adds blank import in pkg/mcp/modules.go

Adds ovn-kubernetes to the TestGranularToolsetsTools snapshot test with an empty [] snapshot

The toolset ships with zero tools — sibling stories CORENET-7135 (OVS tools) and CORENET-7136 (OVN tools) will add tool handlers on top of this framework.

Verification

make build — binary compiles with the new toolset

make test — all tests pass (including the new snapshot test)

make lint — no lint violations

What is NOT in this PR

No tool implementations (deferred to CORENET-7135/7136/7137/7138)

No ovn-kubernetes-mcp Go dependency (arrives with tool implementations)

No execution adapter / pod-exec changes (depends on CORENET-7133)

No README/docs update (zero tools means empty generated sections)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-05-19T15:23:24Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d2b18601-6d8b-4de8-a66e-4e22f42b7ea7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

📝 Walkthrough

Walkthrough

This PR adds a new OVN-Kubernetes toolset to the OpenShift MCP server. It defines a toolset struct with network troubleshooting capabilities, registers it in the module system, and integrates it into the existing toolset test suite with snapshot validation.

Changes

OVN-Kubernetes Toolset

Layer / File(s)	Summary
OVN-Kubernetes Toolset Implementation `pkg/toolsets/ovnkubernetes/toolset.go`	Defines `Toolset` struct implementing `api.Toolset` with `GetName()` returning `"ovn-kubernetes"`, `GetDescription()` returning `"OVN-Kubernetes CNI network troubleshooting tools"`, and `GetTools`, `GetPrompts`, `GetResources`, `GetResourceTemplates` all returning `nil`. Registers via `init()`.
Module Registration and Test Integration `pkg/mcp/modules.go`, `pkg/mcp/toolsets_test.go`, `pkg/mcp/testdata/toolsets-ovn-kubernetes-tools.json`	Side-effect import in `modules.go` enables toolset initialization. Test import and `TestGranularToolsetsTools` case addition expand snapshot coverage. Test data file provides empty JSON array snapshot.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

A toolset for networks, with OVN's own flair,
Rabbits hop swiftly through troubleshooting care,
Snapshots and tests in a bundle so neat,
One more small hop makes the feature complete! 🐰🔧

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically summarizes the main change: adding a new ovn-kubernetes toolset skeleton with appropriate reference to the tracking ticket.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci · 2026-05-19T15:23:30Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci · 2026-05-19T15:26:22Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mattedallo
Once this PR has been reviewed and has the lgtm label, please assign cali0707 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mattedallo · 2026-05-20T07:20:02Z

/test all

mattedallo · 2026-05-20T07:21:23Z

@coderabbitai review

coderabbitai · 2026-05-20T07:21:29Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

openshift-ci · 2026-05-20T09:36:26Z

@mattedallo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

matzew · 2026-05-21T05:02:23Z

@@ -0,0 +1,38 @@
+package ovnkubernetes


seems pretty empty

why not land this with actual tools (e.g. as go module)?

Hi @matzew, thanks for reviewing!

Yep, we have a followup PRs coming for the tools.
But If you prefer I may add some of them into this PR directly.

yes - I'd think we do not land empty toolsets here

+1 let's at least try to land the first tool in this PR. If you want to then incrementally add some more tools in future PRs that is cool

Thanks @matzew and @Cali0707 for the feedback.
I will update the PR to include the first tools

Hi @matzew and @Cali0707, While adding the tools I am considering this approach:

the upstream exports tool definitions using gosdk.Tool from the go-sdk (a type both repos already depend on), paired with a type-erased execution function. In here we just iterates and converts (From gosdk.Tool to api.Tool) , no manual schema duplication. When upstream adds a new tool, downstream would have the tool automatically with version bump.

The benefit is that we don't duplicate the schema definition and we get the new tools automatically with version bump.
Is this something desired or you see problems with this approach?

matzew · 2026-05-27T14:14:38Z

@mattedallo also, if this new toolset is directly mapping to "upstream" ovn-k8s, I think the right address for PRs like that might be the actual upstream repo. Here, on OCP downstream, we might want to have mostly OCP specifics.

That said, see recent discussion on #122 that for some CRUD tools, it might be also just fine to provide evals and see if those are passing already w/ our core toolset

Register an empty ovn-kubernetes toolset so sibling stories (CORENET-7135/7136) can land OVN/OVS tool handlers on top of this framework. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Matteo Dallaglio <mdallagl@redhat.com>

Import the ovn-kubernetes-mcp library which provides OVN network analysis tools (show, get, lflow-list, trace) as an MCP server. Signed-off-by: Matteo Dallaglio <mdallagl@redhat.com>

Prototype of upstream changes that export tool definitions via AllToolRegistrations() using *mcp.Tool as the shared interface: - Add ExecTarget type for role-based container routing - Add MakeExecute generic helper for type-erased method dispatch - Add TargetSelector per tool (dbTarget, staticTarget) - Export named tool vars (ShowTool, GetTool, LFlowListTool, TraceTool) - Refactor AddTools() to use exported tool vars This is a proof-of-concept — the actual change would be an upstream PR to github.com/ovn-kubernetes/ovn-kubernetes-mcp. Signed-off-by: Matteo Dallaglio <mdallagl@redhat.com>

arkadeepsen · 2026-06-05T18:31:24Z

@mattedallo also, if this new toolset is directly mapping to "upstream" ovn-k8s, I think the right address for PRs like that might be the actual upstream repo. Here, on OCP downstream, we might want to have mostly OCP specifics.

That said, see recent discussion on #122 that for some CRUD tools, it might be also just fine to provide evals and see if those are passing already w/ our core toolset

Hey @matzew, one of the reasons not to add these tools to upstream is because some of the ovnk tools need the node-debug functionality and as per some existing conversations it seems that adding that tool upstream is not in current plans. Additionally, upstream k8s-mcp-server might want to be CNI agnostic whereas for openshift-mcp-server these tools will be very useful as most customers use ovnk as the CNI. We already have a separate upstream repo for ovnk mcp server (https://github.com/ovn-kubernetes/ovn-kubernetes-mcp) and thus adding these tools in k8s-mcp-server will mean that 2 separate upstream projects have the same tools, which probably is not ideal.

I have created an EP (openshift/enhancements#2002) where we can have further discussions on this topic. PTAL.
cc @tssurya

Consume ovn-kubernetes-mcp's AllToolRegistrations() in a generic loop that converts *mcp.Tool to api.Tool and wires handlers automatically. No per-tool knowledge in the downstream — new tools added upstream propagate on go mod vendor with zero code changes here. Signed-off-by: Matteo Dallaglio <mdallagl@redhat.com>

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 19, 2026

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 19, 2026

mattedallo marked this pull request as ready for review May 20, 2026 09:29

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 20, 2026

openshift-ci Bot requested review from Cali0707 and Kaustubh-pande May 20, 2026 09:32

matzew reviewed May 21, 2026

View reviewed changes

mattedallo marked this pull request as draft June 5, 2026 11:29

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2026

mattedallo added 2 commits June 5, 2026 13:31

vendor: add ovn-kubernetes-mcp v0.0.0-20260521143347-5fe0e0972cd5

a9e47c5

Import the ovn-kubernetes-mcp library which provides OVN network analysis tools (show, get, lflow-list, trace) as an MCP server. Signed-off-by: Matteo Dallaglio <mdallagl@redhat.com>

mattedallo force-pushed the corenet-7134-ovnk-toolset branch from 1124f8a to 39da71e Compare June 8, 2026 11:55

arkadeepsen mentioned this pull request Jun 9, 2026

CORENET-7091: Add enhancement proposal to productize ovn-kubernetes MCP tools openshift/enhancements#2002

Open

Conversation

mattedallo commented May 19, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Verification

What is NOT in this PR

Summary by CodeRabbit

Release Notes

Uh oh!

openshift-ci-robot commented May 19, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Verification

What is NOT in this PR

Uh oh!

coderabbitai Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Estimated code review effort

Poem

❌ Failed checks (1 warning)

Uh oh!

openshift-ci Bot commented May 19, 2026

Uh oh!

openshift-ci Bot commented May 19, 2026

Uh oh!

mattedallo commented May 20, 2026

Uh oh!

mattedallo commented May 20, 2026

Uh oh!

coderabbitai Bot commented May 20, 2026

Uh oh!

openshift-ci Bot commented May 20, 2026

Uh oh!

matzew May 21, 2026

Choose a reason for hiding this comment

Uh oh!

mattedallo May 21, 2026

Choose a reason for hiding this comment

Uh oh!

matzew May 27, 2026

Choose a reason for hiding this comment

Uh oh!

Cali0707 May 27, 2026

Choose a reason for hiding this comment

Uh oh!

mattedallo Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

mattedallo Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

matzew commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arkadeepsen commented Jun 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mattedallo commented May 19, 2026 •

edited by coderabbitai Bot

Loading

openshift-ci-robot commented May 19, 2026 •

edited by openshift-ci Bot

Loading

coderabbitai Bot commented May 19, 2026 •

edited

Loading

mattedallo Jun 9, 2026 •

edited

Loading

matzew commented May 27, 2026 •

edited

Loading