Add KarafDistributionOption.systemBundle #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamenco
force-pushed
the
feature_system_bundle
branch
from
108c17b to
8091ee3
Compare
hwellmann
requested changes
Dec 11, 2016
Member
hwellmann
left a comment
hwellmann
left a comment
There was a problem hiding this comment.
Please check README.md in the repository root, add some tests and use the project's formatting style.
Thanks!
| import org.ops4j.pax.exam.options.ProvisionOption; | ||
| import org.ops4j.pax.exam.options.UrlReference; | ||
| import org.ops4j.pax.exam.karaf.options.SystemBundleOption; | ||
| import org.ops4j.pax.exam.options.*; |
| private File file; | ||
|
|
||
|
|
||
| public SystemBundleOption(String aGroup, String artifact, String version, File file) { |
Member
There was a problem hiding this comment.
Add Javadoc to all public classes.
| } | ||
|
|
||
| /** | ||
| * |
| } | ||
|
|
||
| /** | ||
| * |
| if (file != null) { | ||
| try { | ||
| return new RawUrlReference(file.toURI().toURL().toString()); | ||
| } catch (MalformedURLException e) { |
Author
|
Besides these issues, are we OK with combining both adding to system directory AND adding to properties file at same time? |
Author
|
OK. Test added. I did not see any other tests for the standard options though... We probably should add a start level parameter defaulting to '5', but besides that, anything else? |
|
Any progress with this issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ops4j1.jira.com/browse/PAXEXAM-800