-
Notifications
You must be signed in to change notification settings - Fork 293
feat: add content hash for shared libraries #487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add content hash for shared libraries #487
Conversation
|
I couldn't find any information on how this repo accepts contributions. This PR would fix an issue we had in production, is there anything I can do to help get this merged? |
Hi,before a PR can be merged in, it should first be released from draft status. |
6dbd1b8 to
dfb9cd6
Compare
|
There was a change needed so this PR was still in the draft status. I changed the parameters of |
…se/vite-plugin-federation into support-shared-lib-hash-name
Jiannan-dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@ruleeeer Hi, any plans to release this? |
|
curios for the release date too @ruleeeer , thanks |
|
@Sultanyaron @sethsandaru |
|
Is there a way to opt out of the hash in the file name? |
Description
This fixes the problem described in #482.
Shared library build files now receive a content hash in their file name (e.g., __federation_shared_react-000ea6e2.js). With this change, it becomes easier to implement a caching solution in the browser. Consequently, the browser can respond to changes in shared libraries when their content changes.
Caching should now be possible; otherwise, this would have a performance impact. Theotther JavaScript chunks already have hashes, so it is only reasonable to add them here as well.
What is the purpose of this pull request?