From a2034990c8dae7bb05242b39b3a90716fefb3346 Mon Sep 17 00:00:00 2001 From: Rebecca Alpert Date: Wed, 17 Jun 2026 15:12:24 -0400 Subject: [PATCH] fix(AngleRightIcon): Replace AngleRightIcon with RhMicronsCaretRightIcon Co-authored-by: Cursor --- .../examples/DualListSelector.md | 2 +- .../examples/DualListSelectorBasic.tsx | 4 +- .../examples/DualListSelectorBasicSearch.tsx | 4 +- .../DualListSelectorBasicTooltips.tsx | 4 +- .../DualListSelectorComplexOptionsActions.tsx | 4 +- .../examples/DualListSelectorTree.tsx | 4 +- .../Pagination/PaginationNavigation.tsx | 4 +- .../PaginationNavigation.test.tsx.snap | 20 +- .../__snapshots__/Pagination.test.tsx.snap | 420 ++++-------------- .../DualListSelector/DualListSelector.tsx | 4 +- .../DualListSelector.test.tsx.snap | 120 +---- .../examples/DualListSelector.md | 2 +- .../examples/DualListSelectorComposable.tsx | 4 +- .../DualListSelectorComposableDragDrop.tsx | 4 +- .../DualListSelectorComposableTree.tsx | 4 +- .../components/DragDrop/examples/DragDrop.md | 2 +- .../DragDropContainerDualListSelector.tsx | 4 +- .../DragDrop/examples/DragDropDemos.md | 2 +- .../examples/DualListSelectorDraggable.tsx | 4 +- .../DualListSelectorBasicDemo.tsx | 4 +- .../DualListSelectorTreeDemo.tsx | 4 +- .../DualListSelectorWithActionsDemo.tsx | 4 +- 22 files changed, 146 insertions(+), 482 deletions(-) diff --git a/packages/react-core/src/components/DualListSelector/examples/DualListSelector.md b/packages/react-core/src/components/DualListSelector/examples/DualListSelector.md index 451ecb19a2c..62ee2d0d875 100644 --- a/packages/react-core/src/components/DualListSelector/examples/DualListSelector.md +++ b/packages/react-core/src/components/DualListSelector/examples/DualListSelector.md @@ -19,7 +19,7 @@ import { Fragment, useEffect, useMemo, useState } from 'react'; import RhMicronsDoubleCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-double-caret-left-icon'; import RhMicronsCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-left-icon'; import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon'; -import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon'; +import RhMicronsCaretRightIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-right-icon'; import RhMicronsSortDownSmallToLargeIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-sort-down-small-to-large-icon'; import RhUiEllipsisVerticalFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-ellipsis-vertical-fill-icon'; import RhMicronsSearchIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-search-icon'; diff --git a/packages/react-core/src/components/DualListSelector/examples/DualListSelectorBasic.tsx b/packages/react-core/src/components/DualListSelector/examples/DualListSelectorBasic.tsx index 5ab4a8919cd..08cb3838bef 100644 --- a/packages/react-core/src/components/DualListSelector/examples/DualListSelectorBasic.tsx +++ b/packages/react-core/src/components/DualListSelector/examples/DualListSelectorBasic.tsx @@ -10,7 +10,7 @@ import { import RhMicronsDoubleCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-double-caret-left-icon'; import RhMicronsCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-left-icon'; import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon'; -import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon'; +import RhMicronsCaretRightIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-right-icon'; interface Option { text: string; @@ -105,7 +105,7 @@ export const DualListSelectorBasic: React.FunctionComponent = () => { isDisabled={!availableOptions.some((option) => option.selected)} onClick={() => moveSelected(true)} aria-label="Add selected" - icon={} + icon={} /> { isDisabled={!availableOptions.some((option) => option.selected)} onClick={() => moveSelected(true)} aria-label="Add selected" - icon={} + icon={} /> { aria-label="Add selected" tooltipContent="Add selected" tooltipProps={{ position: 'top', 'aria-live': 'off' }} - icon={} + icon={} /> option.selected) || isDisabled} onClick={() => moveSelected(true)} aria-label="Add selected" - icon={} + icon={} /> visibleAvailableLeafIds.includes(x)).length} onClick={() => moveChecked(true)} aria-label="Add selected" - icon={} + icon={} /> } + icon={} /> {!isCompact && ( diff --git a/packages/react-core/src/components/Pagination/__tests__/Generated/__snapshots__/PaginationNavigation.test.tsx.snap b/packages/react-core/src/components/Pagination/__tests__/Generated/__snapshots__/PaginationNavigation.test.tsx.snap index e3309a2e3aa..e7385e1614d 100644 --- a/packages/react-core/src/components/Pagination/__tests__/Generated/__snapshots__/PaginationNavigation.test.tsx.snap +++ b/packages/react-core/src/components/Pagination/__tests__/Generated/__snapshots__/PaginationNavigation.test.tsx.snap @@ -114,24 +114,12 @@ exports[`Navigation should match snapshot (auto-generated) 1`] = ` fill="currentColor" height="1em" role="img" + viewBox="0 0 20 20" width="1em" > - - - - - - + diff --git a/packages/react-core/src/components/Pagination/__tests__/__snapshots__/Pagination.test.tsx.snap b/packages/react-core/src/components/Pagination/__tests__/__snapshots__/Pagination.test.tsx.snap index a3025e0fcaa..4a13188c861 100644 --- a/packages/react-core/src/components/Pagination/__tests__/__snapshots__/Pagination.test.tsx.snap +++ b/packages/react-core/src/components/Pagination/__tests__/__snapshots__/Pagination.test.tsx.snap @@ -178,24 +178,12 @@ exports[`Pagination API verify inset2xl inset breakpoints 1`] = ` fill="currentColor" height="1em" role="img" + viewBox="0 0 20 20" width="1em" > - - - - - - + @@ -427,24 +415,12 @@ exports[`Pagination API verify insetLg inset breakpoints 1`] = ` fill="currentColor" height="1em" role="img" + viewBox="0 0 20 20" width="1em" > - - - - - - + @@ -676,24 +652,12 @@ exports[`Pagination API verify insetMd inset breakpoints 1`] = ` fill="currentColor" height="1em" role="img" + viewBox="0 0 20 20" width="1em" > - - - - - - + @@ -925,24 +889,12 @@ exports[`Pagination API verify insetNone inset breakpoints 1`] = ` fill="currentColor" height="1em" role="img" + viewBox="0 0 20 20" width="1em" > - - - - - - + @@ -1174,24 +1126,12 @@ exports[`Pagination API verify insetSm inset breakpoints 1`] = ` fill="currentColor" height="1em" role="img" + viewBox="0 0 20 20" width="1em" > - - - - - - + @@ -1423,24 +1363,12 @@ exports[`Pagination API verify insetXl inset breakpoints 1`] = ` fill="currentColor" height="1em" role="img" + viewBox="0 0 20 20" width="1em" > - - - - - - + @@ -1663,24 +1591,12 @@ exports[`Pagination component render custom pagination toggle 1`] = ` fill="currentColor" height="1em" role="img" + viewBox="0 0 20 20" width="1em" > - - - - - - + @@ -1916,24 +1832,12 @@ exports[`Pagination component render custom perPageOptions 1`] = ` fill="currentColor" height="1em" role="img" + viewBox="0 0 20 20" width="1em" > - - - - - - + @@ -2167,24 +2071,12 @@ exports[`Pagination component render custom start end 1`] = ` fill="currentColor" height="1em" role="img" + viewBox="0 0 20 20" width="1em" > - - - - - - + @@ -2372,24 +2264,12 @@ exports[`Pagination component render empty per page options 1`] = ` fill="currentColor" height="1em" role="img" + viewBox="0 0 20 20" width="1em" > - - - - - - + @@ -2624,24 +2504,12 @@ exports[`Pagination component render last page 1`] = ` fill="currentColor" height="1em" role="img" + viewBox="0 0 20 20" width="1em" > - - - - - - + @@ -2880,24 +2748,12 @@ exports[`Pagination component render limited number of pages 1`] = ` fill="currentColor" height="1em" role="img" + viewBox="0 0 20 20" width="1em" > - - - - - - + @@ -3122,24 +2978,12 @@ exports[`Pagination component render should render correctly bottom 1`] = ` fill="currentColor" height="1em" role="img" + viewBox="0 0 20 20" width="1em" > - - - - - - + @@ -3363,24 +3207,12 @@ exports[`Pagination component render should render correctly bottom sticky 1`] = fill="currentColor" height="1em" role="img" + viewBox="0 0 20 20" width="1em" > - - - - - - + @@ -3616,24 +3448,12 @@ exports[`Pagination component render should render correctly compact 1`] = ` fill="currentColor" height="1em" role="img" + viewBox="0 0 20 20" width="1em" > - - - - - - + @@ -3872,24 +3692,12 @@ exports[`Pagination component render should render correctly disabled 1`] = ` fill="currentColor" height="1em" role="img" + viewBox="0 0 20 20" width="1em" > - - - - - - + @@ -4126,24 +3934,12 @@ exports[`Pagination component render should render correctly sticky 1`] = ` fill="currentColor" height="1em" role="img" + viewBox="0 0 20 20" width="1em" > - - - - - - + @@ -4379,24 +4175,12 @@ exports[`Pagination component render should render correctly top 1`] = ` fill="currentColor" height="1em" role="img" + viewBox="0 0 20 20" width="1em" > - - - - - - + @@ -4632,24 +4416,12 @@ exports[`Pagination component render titles 1`] = ` fill="currentColor" height="1em" role="img" + viewBox="0 0 20 20" width="1em" > - - - - - - + @@ -4885,24 +4657,12 @@ exports[`Pagination component render up drop direction 1`] = ` fill="currentColor" height="1em" role="img" + viewBox="0 0 20 20" width="1em" > - - - - - - + @@ -5140,24 +4900,12 @@ exports[`Pagination component render zero results 1`] = ` fill="currentColor" height="1em" role="img" + viewBox="0 0 20 20" width="1em" > - - - - - - + diff --git a/packages/react-core/src/deprecated/components/DualListSelector/DualListSelector.tsx b/packages/react-core/src/deprecated/components/DualListSelector/DualListSelector.tsx index 83643cd0bab..97b1b4e2a37 100644 --- a/packages/react-core/src/deprecated/components/DualListSelector/DualListSelector.tsx +++ b/packages/react-core/src/deprecated/components/DualListSelector/DualListSelector.tsx @@ -4,7 +4,7 @@ import { css } from '@patternfly/react-styles'; import RhMicronsDoubleCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-double-caret-left-icon'; import RhMicronsCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-left-icon'; import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon'; -import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon'; +import RhMicronsCaretRightIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-right-icon'; import { DualListSelectorPane } from './DualListSelectorPane'; import { GenerateId, PickOptional } from '../../../helpers'; import { DualListSelectorTreeItemData } from './DualListSelectorTree'; @@ -726,7 +726,7 @@ class DualListSelector extends Component - + - - - - - - + @@ -423,24 +411,12 @@ exports[`DualListSelector basic with disabled controls 1`] = ` fill="currentColor" height="1em" role="img" + viewBox="0 0 20 20" width="1em" > - - - - - - + @@ -733,24 +709,12 @@ exports[`DualListSelector with actions 1`] = ` fill="currentColor" height="1em" role="img" + viewBox="0 0 20 20" width="1em" > - - - - - - + @@ -1095,24 +1059,12 @@ exports[`DualListSelector with custom status 1`] = ` fill="currentColor" height="1em" role="img" + viewBox="0 0 20 20" width="1em" > - - - - - - + @@ -1435,24 +1387,12 @@ exports[`DualListSelector with search inputs 1`] = ` fill="currentColor" height="1em" role="img" + viewBox="0 0 20 20" width="1em" > - - - - - - + @@ -1852,24 +1792,12 @@ exports[`DualListSelector with tree 1`] = ` fill="currentColor" height="1em" role="img" + viewBox="0 0 20 20" width="1em" > - - - - - - + diff --git a/packages/react-core/src/deprecated/components/DualListSelector/examples/DualListSelector.md b/packages/react-core/src/deprecated/components/DualListSelector/examples/DualListSelector.md index 59da4b7db4f..a418cd2d49c 100644 --- a/packages/react-core/src/deprecated/components/DualListSelector/examples/DualListSelector.md +++ b/packages/react-core/src/deprecated/components/DualListSelector/examples/DualListSelector.md @@ -32,7 +32,7 @@ DualListSelectorTree as DLSTreeDeprecated, import RhMicronsDoubleCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-double-caret-left-icon'; import RhMicronsCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-left-icon'; import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon'; -import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon'; +import RhMicronsCaretRightIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-right-icon'; import RhMicronsSortDownSmallToLargeIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-sort-down-small-to-large-icon'; import RhMicronsSearchIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-search-icon'; diff --git a/packages/react-core/src/deprecated/components/DualListSelector/examples/DualListSelectorComposable.tsx b/packages/react-core/src/deprecated/components/DualListSelector/examples/DualListSelectorComposable.tsx index 093c58ebca9..5c768abf412 100644 --- a/packages/react-core/src/deprecated/components/DualListSelector/examples/DualListSelectorComposable.tsx +++ b/packages/react-core/src/deprecated/components/DualListSelector/examples/DualListSelectorComposable.tsx @@ -20,7 +20,7 @@ import { import RhMicronsDoubleCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-double-caret-left-icon'; import RhMicronsCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-left-icon'; import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon'; -import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon'; +import RhMicronsCaretRightIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-right-icon'; import RhMicronsSortDownSmallToLargeIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-sort-down-small-to-large-icon'; import RhMicronsSearchIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-search-icon'; @@ -198,7 +198,7 @@ export const DualListSelectorComposable: React.FunctionComponent = () => { aria-label="Add selected" tooltipContent="Add selected" > - + { const [ignoreNextOptionSelect, setIgnoreNextOptionSelect] = useState(false); @@ -121,7 +121,7 @@ export const DualListSelectorComposableDragDrop: React.FunctionComponent = () => onClick={() => moveSelected(true)} aria-label="Add selected" > - + moveChecked(true)} aria-label="Add selected" > - + { const [ignoreNextOptionSelect, setIgnoreNextOptionSelect] = useState(false); @@ -149,7 +149,7 @@ export const DragDropContainerDualListSelector: React.FunctionComponent = () => onClick={() => moveSelected(true)} aria-label="Add selected" > - + { const [ignoreNextOptionSelect, setIgnoreNextOptionSelect] = useState(false); @@ -102,7 +102,7 @@ export const ComposableDualListSelector: React.FunctionComponent = () => { isDisabled={!availableOptions.some((option) => option.props.isSelected)} onClick={() => moveSelected(true)} aria-label="Add selected" - icon={} + icon={} /> { aria-label="Add selected" tooltipContent="Add selected" tooltipProps={{ position: 'top', 'aria-live': 'off' }} - icon={} + icon={} /> = ({ isDisabled={!checkedLeafIds.filter((x) => visibleAvailableLeafIds.includes(x)).length} onClick={() => moveChecked(true)} aria-label="Add selected" - icon={} + icon={} /> { isDisabled={!availableOptions.some((option) => option.selected) || isDisabled} onClick={() => moveSelected(true)} aria-label="Add selected" - icon={} + icon={} />