Autotools: Use runstatedir for var/run directory#16064
Closed
petk wants to merge 1 commit intophp:masterfrom
Closed
Autotools: Use runstatedir for var/run directory#16064petk wants to merge 1 commit intophp:masterfrom
petk wants to merge 1 commit intophp:masterfrom
Conversation
This removes duplicate substituted variables in FPM SAPI. The
php_fpm_sysconfdir is the same as EXPANDED_SYSCONFDIR and
php_fpm_localstatedir is the same as EXPANDED_LOCALSTATEDIR, which are
already done in the configure.ac.
Instead of hardcoding the var/run directory, the runstatedir can be
used (configured also via the `--runstatedir` configure option). By
default, the runstatedir is `${localstatedir}/run`.
devnexen
approved these changes
Sep 25, 2024
Member
Author
|
Ah. This is only for Autoconf 2.70 and later. As Autoconf minimum version will be probably bumped later on due to that C minimum standard issue, then this can be synced also then. |
Member
Author
|
I think I don't need this. In CMake-based build system patching of these FPM config files is done anyway so even if there is run directory hardcoded, it doesn't cause much issues. And those config files are templates to be heavily further adjusted anyway when using FPM, so I'll just close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes duplicate substituted variables in FPM SAPI. The php_fpm_sysconfdir is the same as EXPANDED_SYSCONFDIR and php_fpm_localstatedir is the same as EXPANDED_LOCALSTATEDIR, which are already done in the configure.ac.
Instead of hardcoding the var/run directory, the runstatedir can be used (configured also via the
--runstatedirconfigure option). By default, the runstatedir is${localstatedir}/run.