Show copied text on copied to clipboard toast #35781
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I'm not sure this will work well if there's a huge amount of text copied. Probably needs some form of truncation. |
Collaborator
|
The fact that the copied text is additionally auto-converted to all caps is turbo weird to me too. I dunno about this. Weird decision to do this in the first place. Don't agree with it. |
Member
|
Probably better to just hide the "no key bound" and not do this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having "no key bound" as the shortcut/hint text doesn't make sense. It could be ctrl-c (when the framework shortcut lookup gets implemented), but it's not really relevant with the "copy link" buttons, only the editor case, and it's a common shortcut most people know about.
Also provides a UX improvement to what gets copied when ctrl-c is pressed in the editor (needs above PR to see).