Add foreign implementation for push (#240)

* Add foreign implementation for push

* Use foreign implementation for push

* Add changelog entry

* Update src/Data/Array/ST.js

Co-authored-by: Thomas Honeyman <[email protected]>

* Update ST.purs

---------

Co-authored-by: Thomas Honeyman <[email protected]>

Author: i-am-the-slime

CHANGELOG.md

@@ -11,6 +11,7 @@ New features:
 Bugfixes:
 
 Other improvements:
+ - Implements `ST.push` via a call to JavaScript's native `push` instead of `pushAll` (#236 by @i-am-the-slime)
 
 ## [v7.2.1](https://github.com/purescript/purescript-arrays/releases/tag/v7.2.1) - 2023-06-13
 

src/Data/Array/ST.js

@@ -105,3 +105,7 @@ export const toAssocArrayImpl = function (xs) {
   for (var i = 0; i < n; i++) as[i] = { value: xs[i], index: i };
   return as;
 };
+
+export const pushImpl = function (a, xs) {
+  return xs.push(a);
+};

src/Data/Array/ST.purs

@@ -181,8 +181,10 @@ foreign import popImpl
 
 -- | Append an element to the end of a mutable array. Returns the new length of
 -- | the array.
-push :: forall h a. a -> STArray h a -> ST h Int
-push a = runSTFn2 pushAllImpl [ a ]
+push :: forall h a. a -> (STArray h a) -> ST h Int
+push = runSTFn2 pushImpl
+
+foreign import pushImpl :: forall h a. STFn2 a (STArray h a) h Int
 
 -- | Append the values in an immutable array to the end of a mutable array.
 -- | Returns the new length of the mutable array.