Merge pull request #48 from pxlrbt/fix/nullable-get-url

pxlrbt · web-flow · commit 0f51cddb52fc · 2024-11-18T20:01:09.000+08:00
fix: `getUrl()` might return null
diff --git a/src/Actions/RegisterUserMenu.php b/src/Actions/RegisterUserMenu.php
@@ -44,7 +44,7 @@ protected function getName(string $key, MenuItem $item): ?string
         };
     }
 
-    protected function getUrl(string $key, MenuItem $item): string
+    protected function getUrl(string $key, MenuItem $item): ?string
     {
         return match ($key) {
             'logout' => $item->getUrl() ?? Filament::getLogoutUrl(),

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ protected function getName(string $key, MenuItem $item): ?string`
`44`	`44`	`};`
`45`	`45`	`}`
`46`	`46`
`47`		`- protected function getUrl(string $key, MenuItem $item): string`
	`47`	`+ protected function getUrl(string $key, MenuItem $item): ?string`
`48`	`48`	`{`
`49`	`49`	`return match ($key) {`
`50`	`50`	`'logout' => $item->getUrl() ?? Filament::getLogoutUrl(),`