Skip to content

Fix semver comparison logic #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fparisio wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −8
Open

Fix semver comparison logic #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions extension_cpp/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
torch
numpy
packaging
6 changes: 2 additions & 4 deletions extension_cpp/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import glob

from setuptools import find_packages, setup
from packaging.version import Version

from torch.utils.cpp_extension import (
CppExtension,
Expand All @@ -18,10 +19,7 @@

library_name = "extension_cpp"

if torch.__version__ >= "2.6.0":
Copy link
Contributor

@mikaylagawarecki mikaylagawarecki Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From PR description, are you saying this check is evaluating to false when you install pytorch 2.10? I'm surprised to hear that

py_limited_api = True
else:
py_limited_api = False
py_limited_api = Version(torch.__version__) >= Version("2.6.0")


def get_extensions():
Expand Down
1 change: 1 addition & 0 deletions extension_cpp_stable/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
torch
numpy
packaging
6 changes: 2 additions & 4 deletions extension_cpp_stable/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import glob

from setuptools import find_packages, setup
from packaging.version import Version

from torch.utils.cpp_extension import (
CppExtension,
Expand All @@ -19,10 +20,7 @@
library_name = "extension_cpp_stable"


if torch.__version__ >= "2.6.0":
py_limited_api = True
else:
py_limited_api = False
py_limited_api = Version(torch.__version__) >= Version("2.6.0")


def get_extensions():
Expand Down
Loading