Skip to content

Commit d840b41

Browse files
authored
Merge pull request #48390 from gsmet/3.23.4-backports-1
[3.23] 3.23.4 backports 1
2 parents 7ab57a6 + fda7db7 commit d840b41

File tree

31 files changed

+484
-125
lines changed

31 files changed

+484
-125
lines changed

.github/dependabot.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,12 +81,13 @@ updates:
8181
- dependency-name: org.awaitility:awaitility
8282
- dependency-name: com.thoughtworks.xstream:xstream
8383
- dependency-name: org.jacoco:*
84-
# Maven plugins
84+
# Maven plugins and extensions
8585
- dependency-name: org.apache.maven.plugins:*
8686
- dependency-name: org.codehaus.mojo:*
8787
- dependency-name: io.fabric8:docker-maven-plugin
8888
- dependency-name: net.revelc.code.formatter:formatter-maven-plugin
8989
- dependency-name: net.revelc.code:impsort-maven-plugin
90+
- dependency-name: eu.maveniverse.maven.njord:*
9091
# Narayana
9192
- dependency-name: org.jboss.narayana.jta:*
9293
- dependency-name: org.jboss.narayana.jts:*

.mvn/extensions.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,6 @@
2727
<extension>
2828
<groupId>eu.maveniverse.maven.njord</groupId>
2929
<artifactId>extension</artifactId>
30-
<version>0.7.4</version>
30+
<version>0.7.5</version>
3131
</extension>
3232
</extensions>

bom/application/pom.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,10 @@
4747
<microprofile-lra.version>2.0.1</microprofile-lra.version>
4848
<microprofile-openapi.version>4.0.2</microprofile-openapi.version>
4949
<smallrye-common.version>2.12.0</smallrye-common.version>
50-
<smallrye-config.version>3.13.1</smallrye-config.version>
50+
<smallrye-config.version>3.13.2</smallrye-config.version>
5151
<smallrye-health.version>4.2.0</smallrye-health.version>
5252
<smallrye-metrics.version>4.0.0</smallrye-metrics.version>
53-
<smallrye-open-api.version>4.0.10</smallrye-open-api.version>
53+
<smallrye-open-api.version>4.0.11</smallrye-open-api.version>
5454
<smallrye-graphql.version>2.13.0</smallrye-graphql.version>
5555
<smallrye-fault-tolerance.version>6.9.1</smallrye-fault-tolerance.version>
5656
<smallrye-jwt.version>4.6.2</smallrye-jwt.version>
@@ -119,7 +119,7 @@
119119
<quartz.version>2.5.0</quartz.version>
120120
<h2.version>2.3.230</h2.version> <!-- When updating, needs to be matched in io.quarkus.hibernate.orm.runtime.config.DialectVersions
121121
and the dependency jts-core needs to be updated in extensions/jdbc/jdbc-h2/runtime/pom.xml -->
122-
<postgresql-jdbc.version>42.7.6</postgresql-jdbc.version>
122+
<postgresql-jdbc.version>42.7.7</postgresql-jdbc.version>
123123
<mariadb-jdbc.version>3.5.3</mariadb-jdbc.version>
124124
<mysql-jdbc.version>8.3.0</mysql-jdbc.version>
125125
<mssql-jdbc.version>12.8.1.jre11</mssql-jdbc.version>
@@ -194,7 +194,7 @@
194194
<log4j2-api.version>2.24.3</log4j2-api.version>
195195
<log4j-jboss-logmanager.version>1.3.1.Final</log4j-jboss-logmanager.version>
196196
<avro.version>1.12.0</avro.version>
197-
<apicurio-registry.version>2.6.9.Final</apicurio-registry.version>
197+
<apicurio-registry.version>2.6.12.Final</apicurio-registry.version>
198198
<apicurio-common-rest-client.version>0.1.18.Final</apicurio-common-rest-client.version> <!-- must be the version Apicurio Registry uses -->
199199
<testcontainers.version>1.21.1</testcontainers.version> <!-- Make sure to also update docker-java.version to match its needs -->
200200
<docker-java.version>3.4.2</docker-java.version> <!-- must be the version Testcontainers use: https://central.sonatype.com/artifact/org.testcontainers/testcontainers -->

build-parent/pom.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -136,9 +136,6 @@
136136
<!-- The message that is appended to the end of the plugin error output when the API problems fail the build -->
137137
<revapi.buildFailureMessage>Run "jbang revapi-update" to update api-changes.xml file and also add the justification for those changes in that file.</revapi.buildFailureMessage>
138138

139-
<!-- Forbidden API checks -->
140-
<forbiddenapis-maven-plugin.version>3.4</forbiddenapis-maven-plugin.version>
141-
142139
<!-- platform properties - this is a floating tag -->
143140
<platform.quarkus.native.builder-image>mandrel</platform.quarkus.native.builder-image>
144141

@@ -622,7 +619,6 @@
622619
<plugin>
623620
<groupId>de.thetaphi</groupId>
624621
<artifactId>forbiddenapis</artifactId>
625-
<version>${forbiddenapis-maven-plugin.version}</version>
626622
<executions>
627623
<execution>
628624
<id>verify-forbidden-apis</id>

devtools/gradle/gradle-application-plugin/src/main/java/io/quarkus/gradle/QuarkusPlugin.java

Lines changed: 18 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -249,9 +249,9 @@ private void registerTasks(Project project, QuarkusPluginExtension quarkusExt) {
249249
QuarkusBuildDependencies.class,
250250
task -> {
251251
configureQuarkusBuildTask(project, task, quarkusBuildAppModelTask, serviceProvider);
252-
253252
task.getOutputs().doNotCacheIf("Dependencies are never cached", t -> true);
254253
});
254+
project.afterEvaluate(evaluated -> addDependencyOnJandexIfConfigured(evaluated, quarkusBuildDependencies));
255255

256256
Property<Boolean> cacheLargeArtifacts = quarkusExt.getCacheLargeArtifacts();
257257

@@ -646,7 +646,7 @@ private void visitProjectDep(Project project, Project dep, Set<String> visited)
646646
}
647647

648648
private void setupQuarkusBuildTaskDeps(Project project, Project dep, Set<String> visited) {
649-
if (!visited.add(dep.getGroup() + ":" + dep.getName())) {
649+
if (!visited.add(dep.getPath())) {
650650
return;
651651
}
652652

@@ -663,18 +663,24 @@ private void setupQuarkusBuildTaskDeps(Project project, Project dep, Set<String>
663663
});
664664

665665
getLazyTask(project, QUARKUS_DEV_TASK_NAME).ifPresent(quarkusDev -> {
666-
for (String taskName : new String[] { JavaPlugin.PROCESS_RESOURCES_TASK_NAME,
667-
// This is the task of the 'org.kordamp.gradle.jandex' Gradle plugin
668-
"jandex",
669-
// This is the task of the 'com.github.vlsi.jandex' Gradle plugin
670-
"processJandexIndex" }) {
671-
getLazyTask(dep, taskName).ifPresent(t -> quarkusDev.configure(qd -> qd.dependsOn(t)));
672-
}
666+
getLazyTask(project, JavaPlugin.PROCESS_RESOURCES_TASK_NAME)
667+
.ifPresent(t -> quarkusDev.configure(qd -> qd.dependsOn(t)));
668+
addDependencyOnJandexIfConfigured(dep, quarkusDev);
673669
});
674670

675671
visitProjectDependencies(project, dep, visited);
676672
}
677673

674+
private void addDependencyOnJandexIfConfigured(Project project, TaskProvider<? extends Task> quarkusTask) {
675+
for (String taskName : new String[] {
676+
// This is the task of the 'org.kordamp.gradle.jandex' Gradle plugin
677+
"jandex",
678+
// This is the task of the 'com.github.vlsi.jandex' Gradle plugin
679+
"processJandexIndex" }) {
680+
getLazyTask(project, taskName).ifPresent(t -> quarkusTask.configure(qd -> qd.mustRunAfter(t)));
681+
}
682+
}
683+
678684
protected void visitProjectDependencies(Project project, Project dep, Set<String> visited) {
679685
final Configuration compileConfig = dep.getConfigurations().findByName(JavaPlugin.COMPILE_CLASSPATH_CONFIGURATION_NAME);
680686
if (compileConfig != null) {
@@ -711,13 +717,9 @@ protected void visitProjectDependencies(Project project, Project dep, Set<String
711717
private void visitLocalProject(Project project, Project localProject, Set<String> visited) {
712718
// local dependency, so we collect also its dependencies
713719
visitProjectDep(project, localProject, visited);
714-
715-
ExtensionDependency<?> extensionDependency = DependencyUtils
716-
.getExtensionInfoOrNull(project, localProject);
717-
718-
if (extensionDependency instanceof ProjectExtensionDependency) {
719-
visitProjectDep(project,
720-
((ProjectExtensionDependency) extensionDependency).getDeploymentModule(), visited);
720+
ExtensionDependency<?> extensionDependency = DependencyUtils.getExtensionInfoOrNull(project, localProject);
721+
if (extensionDependency instanceof ProjectExtensionDependency projectExtDep) {
722+
visitProjectDep(project, projectExtDep.getDeploymentModule(), visited);
721723
}
722724
}
723725

devtools/gradle/gradle/libs.versions.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ plugin-publish = "1.3.1"
33

44
# updating Kotlin here makes QuarkusPluginTest > shouldNotFailOnProjectDependenciesWithoutMain(Path) fail
55
kotlin = "2.0.21"
6-
smallrye-config = "3.13.1"
6+
smallrye-config = "3.13.2"
77

88
junit5 = "5.12.2"
99
assertj = "3.27.3"

docs/src/main/asciidoc/config-mappings.adoc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -537,6 +537,7 @@ requires a spy:
537537
[source,java]
538538
----
539539
@ConfigMapping(prefix = "app")
540+
@Unremovable
540541
public interface AppConfig {
541542
@WithDefault("app")
542543
String name();

docs/src/main/asciidoc/vertx-reference.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -704,7 +704,7 @@ The `EventBus` object provides methods to:
704704
[source, java]
705705
----
706706
// Case 1
707-
bus.sendAndForget("greeting", name)
707+
bus.send("greeting", name)
708708
// Case 2
709709
bus.publish("greeting", name)
710710
// Case 3
@@ -730,7 +730,7 @@ Read xref:./virtual-threads.adoc[the virtual thread guide] for more details.
730730

731731
=== Use codecs
732732

733-
The https://vertx.io/docs/vertx-core/java/#event_bus[Vert.x Event Bus] uses https://vertx.io/docs/vertx-core/java/#_message_codecs[codecs] to _serialize_ and _deserialize_ message objects.
733+
The link:++https://vertx.io/docs/vertx-core/java/#event_bus++[Vert.x Event Bus] uses link:++https://vertx.io/docs/vertx-core/java/#_message_codecs++[codecs] to _serialize_ and _deserialize_ message objects.
734734
Quarkus provides a default codec for local delivery.
735735
This codec is automatically used for return types and message body parameters of local consumers, i.e. methods annotated with `@ConsumeEvent` where `ConsumeEvent#local() == true` (which is the default).
736736

extensions/devservices/common/src/main/java/io/quarkus/devservices/common/DatasourceServiceConfigurator.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,13 @@ default String getJdbcUrl(ContainerAddress containerAddress, String databaseName
2121

2222
String getJdbcPrefix();
2323

24+
default String getParametersStartCharacter() {
25+
return "?";
26+
}
27+
2428
default String getParameters(Map<String, String> labels) {
2529
String parameters = labels.get(Labels.COMPOSE_JDBC_PARAMETERS);
26-
return StringUtil.isNullOrEmpty(parameters) ? "" : "?" + parameters;
30+
return StringUtil.isNullOrEmpty(parameters) ? "" : getParametersStartCharacter() + parameters;
2731
}
2832

2933
}

extensions/devservices/deployment/src/main/java/io/quarkus/devservices/deployment/compose/ComposeServiceWaitStrategyTarget.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55

66
import java.util.Arrays;
77
import java.util.List;
8+
import java.util.Objects;
89
import java.util.concurrent.atomic.AtomicReference;
910
import java.util.function.Supplier;
1011

@@ -31,7 +32,11 @@ public class ComposeServiceWaitStrategyTarget implements WaitStrategyTarget, Sup
3132
public ComposeServiceWaitStrategyTarget(DockerClient dockerClient, Container container) {
3233
this.dockerClient = dockerClient;
3334
this.container = container;
34-
this.exposedPorts = Arrays.stream(container.getPorts()).map(ContainerPort::getPrivatePort).toList();
35+
this.exposedPorts = Arrays.stream(container.getPorts())
36+
.filter(port -> port.getPublicPort() != null)
37+
.map(ContainerPort::getPrivatePort)
38+
.filter(Objects::nonNull)
39+
.toList();
3540
}
3641

3742
@Override

0 commit comments

Comments
 (0)