Merge pull request #15155 from rabbitmq/refactor-selenium-test

michaelklishin · web-flow · commit fd34831aae9c · 2025-12-17T15:55:35.000-08:00
Refactor selenium tests
diff --git a/.github/workflows/test-management-ui-for-pr.yaml b/.github/workflows/test-management-ui-for-pr.yaml
@@ -78,3 +78,4 @@ jobs:
       with:
         name: test-artifacts-${{ matrix.browser }}-${{ matrix.erlang_version }}
         path: ${{ env.SELENIUM_ARTIFACTS }}/*
+ 
diff --git a/.github/workflows/test-management-ui.yaml b/.github/workflows/test-management-ui.yaml
@@ -11,6 +11,9 @@ on:
       - 'scripts/**'
       - 'selenium/**'
       - .github/workflows/test-management-ui.yaml
+  pull_request:
+    paths:  # Run full suite on demand on a PR by touching .github/workflows/test-management-ui-for-pr.yaml 
+      - .github/workflows/test-management-ui-for-pr.yaml
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
diff --git a/selenium/test/basic-auth/ac-administrator-without-vhost-permissions.js b/selenium/test/basic-auth/ac-administrator-without-vhost-permissions.js
@@ -8,7 +8,7 @@ const OverviewPage = require('../pageobjects/OverviewPage')
 const AdminTab = require('../pageobjects/AdminTab')
 
 describe('administrator user without any vhosts permissions', function () {
-  let homePage
+  let driver
   let captureScreen
 
   before(async function () {
diff --git a/selenium/test/basic-auth/ac-management-without-vhost-permissions.js b/selenium/test/basic-auth/ac-management-without-vhost-permissions.js
@@ -8,7 +8,7 @@ const OverviewPage = require('../pageobjects/OverviewPage')
 const AdminTab = require('../pageobjects/AdminTab')
 
 describe('management user without any vhosts permissions', function () {
-  let homePage
+  let driver
   let captureScreen
 
   before(async function () {
diff --git a/selenium/test/basic-auth/ac-management.js b/selenium/test/basic-auth/ac-management.js
@@ -9,7 +9,7 @@ const AdminTab = require('../pageobjects/AdminTab')
 const LimitsAdminTab = require('../pageobjects/LimitsAdminTab')
 
 describe('management user with vhosts permissions', function () {
-  let homePage
+  let driver
   let captureScreen
 
   before(async function () {
diff --git a/selenium/test/basic-auth/ac-monitoring-without-vhost-permissions.js b/selenium/test/basic-auth/ac-monitoring-without-vhost-permissions.js
@@ -8,7 +8,7 @@ const OverviewPage = require('../pageobjects/OverviewPage')
 const AdminTab = require('../pageobjects/AdminTab')
 
 describe('monitoring user without any vhosts permissions', function () {
-  let homePage
+  let driver
   let captureScreen
 
   before(async function () {
diff --git a/selenium/test/basic-auth/landing.js b/selenium/test/basic-auth/landing.js
@@ -6,7 +6,7 @@ const { buildDriver, goToHome, captureScreensFor, teardown } = require('../utils
 const LoginPage = require('../pageobjects/LoginPage')
 
 describe('A management user without vhost permissions', function () {
-  let homePage
+  let driver
   let captureScreen
 
   before(async function () {
diff --git a/selenium/test/basic-auth/logout.js b/selenium/test/basic-auth/logout.js
@@ -7,6 +7,7 @@ const LoginPage = require('../pageobjects/LoginPage')
 const OverviewPage = require('../pageobjects/OverviewPage')
 
 describe('When a logged in user', function () {
+  let driver
   let overview
   let loginPage
   let captureScreen
diff --git a/selenium/test/basic-auth/session-expired.js b/selenium/test/basic-auth/session-expired.js
@@ -7,8 +7,7 @@ const LoginPage = require('../pageobjects/LoginPage')
 const OverviewPage = require('../pageobjects/OverviewPage')
 
 describe('Once user is logged in', function () {
-  let homePage
-  let idpLogin
+  let driver
   let overview
   let captureScreen
   this.timeout(65000) // hard-coded to 25secs because this test requires 35sec to run
diff --git a/selenium/test/basic-auth/unauthorized.js b/selenium/test/basic-auth/unauthorized.js
@@ -7,8 +7,7 @@ const LoginPage = require('../pageobjects/LoginPage')
 const OverviewPage = require('../pageobjects/OverviewPage')
 
 describe('An user without management tag', function () {
-  let homePage
-  let idpLogin
+  let driver
   let overview
   let captureScreen
 
diff --git a/selenium/test/connections/amqp10/sessions-for-monitoring-user.js b/selenium/test/connections/amqp10/sessions-for-monitoring-user.js
@@ -24,7 +24,8 @@ onceAmqp('sendable', function (context) {
 })
 
 
-describe('Given an amqp10 connection opened, listed and clicked on it', function () {  
+describe('Given an amqp10 connection opened, listed and clicked on it', function () {
+  let driver
   let captureScreen
   let connectionsPage
   let connectionPage
diff --git a/selenium/test/connections/mqtt/list-connections.js b/selenium/test/connections/mqtt/list-connections.js
@@ -10,6 +10,7 @@ const ConnectionsPage = require('../../pageobjects/ConnectionsPage');
 
 
 describe('List MQTT connections', function () {
+  let driver
   let login
   let overview
   let captureScreen
diff --git a/selenium/test/definitions/export.js b/selenium/test/definitions/export.js
@@ -1,12 +1,13 @@
 const { By, Key, until, Builder } = require('selenium-webdriver')
 require('chromedriver')
 const assert = require('assert')
-const { buildDriver, goToHome, captureScreensFor, teardown, delay } = require('../utils')
+const { buildDriver, goToHome, captureScreensFor, teardown } = require('../utils')
 
 const LoginPage = require('../pageobjects/LoginPage')
 const OverviewPage = require('../pageobjects/OverviewPage')
 
 describe('Export definititions', function () {
+  let driver
   let login
   let overview
   let captureScreen
diff --git a/selenium/test/definitions/import.js b/selenium/test/definitions/import.js
@@ -1,13 +1,14 @@
 const { By, Key, until, Builder } = require('selenium-webdriver')
 require('chromedriver')
 const assert = require('assert')
-const { buildDriver, goToHome, captureScreensFor, teardown, delay } = require('../utils')
+const { buildDriver, goToHome, captureScreensFor, teardown } = require('../utils')
 
 const LoginPage = require('../pageobjects/LoginPage')
 const OverviewPage = require('../pageobjects/OverviewPage')
 const AdminTab = require('../pageobjects/AdminTab')
 
 describe('Import definititions', function () {
+  let driver
   let login
   let overview
   let captureScreen
diff --git a/selenium/test/exchanges/management.js b/selenium/test/exchanges/management.js
@@ -1,7 +1,7 @@
 const { By, Key, until, Builder } = require('selenium-webdriver')
 require('chromedriver')
 const assert = require('assert')
-const { buildDriver, goToHome, captureScreensFor, teardown, doUntil, log } = require('../utils')
+const { buildDriver, goToHome, captureScreensFor, teardown } = require('../utils')
 
 const LoginPage = require('../pageobjects/LoginPage')
 const OverviewPage = require('../pageobjects/OverviewPage')
@@ -11,6 +11,7 @@ const ExchangePage = require('../pageobjects/ExchangePage')
 const DISABLE_METRICS = process.env.DISABLE_METRICS || false
 
 describe('Exchange management', function () {
+  let driver
   let login
   let exchanges
   let exchange
diff --git a/selenium/test/feature-flags/feature-flags.js b/selenium/test/feature-flags/feature-flags.js
@@ -1,14 +1,15 @@
 const { By, Key, until, Builder } = require('selenium-webdriver')
 require('chromedriver')
 const assert = require('assert')
-const { buildDriver, goToHome, captureScreensFor, teardown, findTableRow, delay } = require('../utils')
+const { buildDriver, goToHome, captureScreensFor, teardown } = require('../utils')
 
 const LoginPage = require('../pageobjects/LoginPage')
 const OverviewPage = require('../pageobjects/OverviewPage')
 const AdminTab = require('../pageobjects/AdminTab')
 const FeatureFlagsAdminTab = require('../pageobjects/FeatureFlagsAdminTab')
 
 describe('Feature flags in Admin tab', function () {
+  let driver
   let login
   let overview
   let ffTab
diff --git a/selenium/test/oauth/with-basic-auth-idp-down/happy-login.js b/selenium/test/oauth/with-basic-auth-idp-down/happy-login.js
@@ -7,6 +7,7 @@ const SSOHomePage = require('../../pageobjects/SSOHomePage')
 const OverviewPage = require('../../pageobjects/OverviewPage')
 
 describe('When basic authentication is enabled but UAA is down', function () {
+  let driver
   let homePage
   let overview
   let captureScreen
diff --git a/selenium/test/oauth/with-basic-auth/happy-login.js b/selenium/test/oauth/with-basic-auth/happy-login.js
@@ -7,6 +7,7 @@ const SSOHomePage = require('../../pageobjects/SSOHomePage')
 const OverviewPage = require('../../pageobjects/OverviewPage')
 
 describe('An user with administrator tag', function () {
+  let driver
   let homePage
   let idpLogin
   let overview
diff --git a/selenium/test/oauth/with-basic-auth/landing.js b/selenium/test/oauth/with-basic-auth/landing.js
@@ -6,6 +6,7 @@ const { buildDriver, goToHome, captureScreensFor, teardown } = require('../../ut
 const SSOHomePage = require('../../pageobjects/SSOHomePage')
 
 describe('A user which accesses any protected URL without a session where basic auth is enabled', function () {
+  let driver
   let homePage
   let captureScreen
 
diff --git a/selenium/test/oauth/with-basic-auth/unauthorized.js b/selenium/test/oauth/with-basic-auth/unauthorized.js
@@ -7,6 +7,7 @@ const SSOHomePage = require('../../pageobjects/SSOHomePage')
 const OverviewPage = require('../../pageobjects/OverviewPage')
 
 describe('An user without management tag', function () {
+  let driver
   let homePage
   let idpLogin
   let overview
diff --git a/selenium/test/oauth/with-idp-initiated-via-proxy/happy-login.js b/selenium/test/oauth/with-idp-initiated-via-proxy/happy-login.js
@@ -1,16 +1,15 @@
 const { By, Key, until, Builder } = require('selenium-webdriver')
 require('chromedriver')
 const assert = require('assert')
-const { buildDriver, goToLogin, goToHome, captureScreensFor, teardown } = require('../../utils')
+const { buildDriver, goToHome, captureScreensFor, teardown } = require('../../utils')
 
 const OverviewPage = require('../../pageobjects/OverviewPage')
 
 describe('A user with a JWT token', function () {
+  let driver
   let overview
   let captureScreen
-  let token
-  let fakePortal
-
+  
   before(async function () {
     driver = buildDriver()
     overview = new OverviewPage(driver)
diff --git a/selenium/test/oauth/with-idp-initiated/happy-login.js b/selenium/test/oauth/with-idp-initiated/happy-login.js
@@ -1,18 +1,17 @@
 const { By, Key, until, Builder } = require('selenium-webdriver')
 require('chromedriver')
 const assert = require('assert')
-const { buildDriver, goToLogin, goTo, tokenFor, captureScreensFor, teardown } = require('../../utils')
+const { buildDriver, captureScreensFor, teardown } = require('../../utils')
 
 const OverviewPage = require('../../pageobjects/OverviewPage')
 const FakePortalPage = require('../../pageobjects/FakePortalPage')
 
 describe('A user with a JWT token', function () {
+  let driver
   let overview
   let captureScreen
-  let token
   let fakePortal
-  let driver
-
+  
   before(async function () {
     driver = buildDriver()
     overview = new OverviewPage(driver)
diff --git a/selenium/test/oauth/with-idp-initiated/landing.js b/selenium/test/oauth/with-idp-initiated/landing.js
@@ -7,6 +7,7 @@ const FakePortalPage = require('../../pageobjects/FakePortalPage')
 const SSOHomePage = require('../../pageobjects/SSOHomePage')
 
 describe('A user which accesses any protected URL without a session', function () {
+  let driver
   let homePage
   let fakePortal
   let captureScreen
diff --git a/selenium/test/oauth/with-idp-initiated/logout.js b/selenium/test/oauth/with-idp-initiated/logout.js
@@ -1,12 +1,13 @@
 const { By, Key, until, Builder } = require('selenium-webdriver')
 require('chromedriver')
 const assert = require('assert')
-const { buildDriver, goToLogin, tokenFor, captureScreensFor, teardown } = require('../../utils')
+const { buildDriver, captureScreensFor, teardown } = require('../../utils')
 
 const OverviewPage = require('../../pageobjects/OverviewPage')
 const FakePortalPage = require('../../pageobjects/FakePortalPage')
 
 describe('When a logged in user', function () {
+  let driver
   let overview
   let fakePortal
   let captureScreen
diff --git a/selenium/test/oauth/with-idp-initiated/token-expires.js b/selenium/test/oauth/with-idp-initiated/token-expires.js
@@ -1,13 +1,14 @@
 const { By, Key, until, Builder } = require('selenium-webdriver')
 require('chromedriver')
 const assert = require('assert')
-const { buildDriver, goToLogin, tokenFor, captureScreensFor, teardown, delay } = require('../../utils')
+const { buildDriver, captureScreensFor, teardown, delay } = require('../../utils')
 
 const OverviewPage = require('../../pageobjects/OverviewPage')
 const SSOHomePage = require('../../pageobjects/SSOHomePage')
 const FakePortalPage = require('../../pageobjects/FakePortalPage')
 
 describe('Once user logs in with its own token', function () {
+  let driver
   let overview
   let homePage
   let fakePortal
diff --git a/selenium/test/oauth/with-idp-initiated/unauthorized.js b/selenium/test/oauth/with-idp-initiated/unauthorized.js
@@ -1,16 +1,15 @@
 const { By, Key, until, Builder } = require('selenium-webdriver')
 require('chromedriver')
 const assert = require('assert')
-const { buildDriver, goToLogin, tokenFor, captureScreensFor, teardown } = require('../../utils')
+const { buildDriver, captureScreensFor, teardown } = require('../../utils')
 
 const SSOHomePage = require('../../pageobjects/SSOHomePage')
 const FakePortalPage = require('../../pageobjects/FakePortalPage')
 
 describe('A user who accesses the /login URL with a token without scopes for the management UI', function () {
-  let overview
+  let driver
   let captureScreen
-  let token
-
+  
   before(async function () {
     driver = buildDriver()
     captureScreen = captureScreensFor(driver, __filename)
diff --git a/selenium/test/oauth/with-multi-resources/happy-login.js b/selenium/test/oauth/with-multi-resources/happy-login.js
@@ -8,6 +8,7 @@ const OverviewPage = require('../../pageobjects/OverviewPage')
 const FakePortalPage = require('../../pageobjects/FakePortalPage')
 
 describe('When there two OAuth resources', function () {
+  let driver
   let homePage
   let idpLogin
   let overview
diff --git a/selenium/test/oauth/with-multi-resources/landing.js b/selenium/test/oauth/with-multi-resources/landing.js
@@ -6,6 +6,7 @@ const { buildDriver, goToHome, captureScreensFor, teardown } = require('../../ut
 const SSOHomePage = require('../../pageobjects/SSOHomePage')
 
 describe('A user which accesses any protected URL without a session', function () {
+  let driver
   let homePage
   let captureScreen
 
diff --git a/selenium/test/oauth/with-sp-initiated/happy-login.js b/selenium/test/oauth/with-sp-initiated/happy-login.js
@@ -7,12 +7,12 @@ const SSOHomePage = require('../../pageobjects/SSOHomePage')
 const OverviewPage = require('../../pageobjects/OverviewPage')
 
 describe('An user with administrator tag', function () {
+  let driver
   let homePage
   let idpLogin
   let overview
   let captureScreen
-  var driver
-
+  
   before(async function () {
     driver = buildDriver()
     await goToHome(driver)
diff --git a/selenium/test/oauth/with-sp-initiated/landing.js b/selenium/test/oauth/with-sp-initiated/landing.js
@@ -6,10 +6,10 @@ const { buildDriver, goToHome, captureScreensFor, teardown } = require('../../ut
 const SSOHomePage = require('../../pageobjects/SSOHomePage')
 
 describe('A user which accesses any protected URL without a session', function () {
+  let driver
   let homePage
   let captureScreen
-  let driver
-
+  
   before(async function () {
     driver = buildDriver()
     await goToHome(driver)
diff --git a/selenium/test/oauth/with-sp-initiated/logout.js b/selenium/test/oauth/with-sp-initiated/logout.js
@@ -7,12 +7,12 @@ const SSOHomePage = require('../../pageobjects/SSOHomePage')
 const OverviewPage = require('../../pageobjects/OverviewPage')
 
 describe('When a logged in user', function () {
+  let driver 
   let overview
   let homePage
   let captureScreen
   let idpLogin
-  let driver 
-
+  
   before(async function () {
     driver = buildDriver()
     await goToHome(driver)
diff --git a/selenium/test/oauth/with-sp-initiated/redirection-after-login.js b/selenium/test/oauth/with-sp-initiated/redirection-after-login.js
@@ -8,6 +8,7 @@ const UAALoginPage = require('../../pageobjects/UAALoginPage')
 const ExchangesPage = require('../../pageobjects/ExchangesPage')
 
 describe('A user which accesses a protected URL without a session', function () {
+  let driver 
   let homePage
   let idpLogin
   let exchanges
diff --git a/selenium/test/oauth/with-sp-initiated/token-refresh.js b/selenium/test/oauth/with-sp-initiated/token-refresh.js
@@ -9,11 +9,12 @@ const KeycloakLoginPage = require('../../pageobjects/KeycloakLoginPage')
 const OverviewPage = require('../../pageobjects/OverviewPage')
 
 describe('Once user is logged in', function () {
+  let driver
   let homePage
   let idpLogin
   let overview
   let captureScreen
-  let driver
+  
   this.timeout(45000) // hard-coded to 25secs because this test requires 35sec to run
 
   before(async function () {
diff --git a/selenium/test/oauth/with-sp-initiated/unauthorized.js b/selenium/test/oauth/with-sp-initiated/unauthorized.js
@@ -7,11 +7,11 @@ const SSOHomePage = require('../../pageobjects/SSOHomePage')
 const OverviewPage = require('../../pageobjects/OverviewPage')
 
 describe('An user without management tag', function () {
+  let driver
   let homePage
   let idpLogin
   let overview
   let captureScreen
-  let driver
 
   before(async function () {
     driver = buildDriver()
diff --git a/selenium/test/queuesAndStreams/add-classic.js b/selenium/test/queuesAndStreams/add-classic.js
diff --git a/selenium/test/queuesAndStreams/add-quorum.js b/selenium/test/queuesAndStreams/add-quorum.js
diff --git a/selenium/test/queuesAndStreams/add-stream.js b/selenium/test/queuesAndStreams/add-stream.js
diff --git a/selenium/test/queuesAndStreams/autodelete-mqtt-qos0.js b/selenium/test/queuesAndStreams/autodelete-mqtt-qos0.js
diff --git a/selenium/test/queuesAndStreams/list.js b/selenium/test/queuesAndStreams/list.js
diff --git a/selenium/test/queuesAndStreams/view-mqtt-qos0.js b/selenium/test/queuesAndStreams/view-mqtt-qos0.js
diff --git a/selenium/test/queuesAndStreams/view-qq-consumers.js b/selenium/test/queuesAndStreams/view-qq-consumers.js
diff --git a/selenium/test/vhosts/admin-vhosts.js b/selenium/test/vhosts/admin-vhosts.js
