Replace `abort-controller` that has no update 7 years with React Native fork by retyui · Pull Request #57230 · react/react-native

retyui · 2026-06-16T14:41:34Z

Summary:

We had a similar situation with promise package that wasn't maintained for long time, so Hermes team simply forked it https://github.com/facebook/hermes/blob/adf76f44a5175455a43c984e7d792015ebc3be2a/lib/InternalJavaScript/01-Promise.js#L53 to fix impl. issues and add more features

Changes:

Remove abort-controller (and event-target-shim as subdep.) packages
Move abort-controller/src files to the packages/react-native/src/private/webapis/dom/abort-api/ folder
Adapt existing tests to react-native env.
Add missing methods:
- AbortSignal.abort(reason),
- AbortSignal.any(signals),
- AbortSignal.timeout(time),
- signal.throwIfAborted();
Cover new methods with tests
Bundle size is smaller as a removed event-target-shim has duplicate logic from packages/react-native/src/private/webapis/dom/events/EventTarget.js
Typescript types has updated

Changelog:

[GENERAL] [CHANGED] - Replace abort-controller with fork version from react-native

Test Plan:

retyui · 2026-06-22T10:16:33Z

@rubennorte could you please review this PR ?

retyui · 2026-06-29T08:38:53Z

@rubennorte could you please review this PR ?

rubennorte · 2026-06-29T10:15:19Z

@@ -0,0 +1,318 @@
+/**


We've soft-deprecated normal Jest tests for React Native runtime APIs. Please migrate to Fantom (using the -itest suffix).

Also, can we just call this AbortController-itest?

meta-codesync · 2026-06-29T10:22:54Z

@rubennorte has imported this pull request. If you are a Meta employee, you can view this in D110042076.

rubennorte

Thanks for working on this. Please address the feedback so we can merge it.

rubennorte · 2026-06-29T10:32:10Z

+   *   Docs: https:developer.mozilla.org/en-US/docs/Web/API/AbortSignal/timeout_static
+   *   Spec: https://dom.spec.whatwg.org/#dom-abortsignal-timeout
+   */
+  static timeout(timeInMs: number): AbortSignal {


This should also have a static abort method on AbortSignal

you are right, I missed it

rubennorte · 2026-06-29T10:32:24Z

+  static timeout(timeInMs: number): AbortSignal {
+    if (!(timeInMs >= 0)) {
+      throw new TypeError(
+        "Failed to execute 'timeout' on 'AbortSignal': The provided value have to be a non-negative number.",


Nit: ...has to be...

rubennorte · 2026-06-29T10:32:35Z

+   */
+  static any(signals: AbortSignal[]): AbortSignal {
+    if (!Array.isArray(signals)) {
+      throw new Error('The signals value must be an instance of Array');


this should be a TypeError

rubennorte · 2026-06-29T10:33:56Z

+}
+
+const listeners = new WeakMap<AbortSignal, () => void>();
+Object.defineProperty(AbortSignal.prototype, `onabort`, {


Please check "EventHandlerAttributes" to implement this.

Cool, much simpler way to define a onabort

rubennorte · 2026-06-29T10:34:13Z

+});
+
+// `toString()` should return `"[object AbortSignal]"`
+if (typeof Symbol === 'function' && typeof Symbol.toStringTag === 'symbol') {


Yeah, this check is unnecessary

rubennorte · 2026-06-29T10:36:07Z

@@ -0,0 +1,69 @@
+/**
+ * @flow strict


We should have a proper license here. Given that you copied the implementation from an external package, you should keep the original license in the header for this file. Something like:

/** * Based on abort-controller by Toru Nagashima * https://github.com/mysticatea/abort-controller * * Original work Copyright (c) 2017 Toru Nagashima * Modified work Copyright (c) Meta Platforms, Inc. and affiliates. * * Permission is hereby granted, free of charge, to any person obtaining a copy * of this software and associated documentation files (the "Software"), to deal * in the Software without restriction, including without limitation the rights * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell * copies of the Software, and to permit persons to whom the Software is * furnished to do so, subject to the following conditions: * * The above copyright notice and this permission notice shall be included in all * copies or substantial portions of the Software. * * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE * SOFTWARE. * * @flow strict * @format */

rubennorte · 2026-06-29T10:51:31Z

+  /**
+   * Returns the `AbortSignal` object associated with this object.
+   */
+  // $FlowExpectedError[unsafe-getters-setters]


Could you please disable the lint instead at the top of the file via // flowlint unsafe-getters-setters:off, like we do in

react-native/packages/react-native/src/private/webapis/dom/events/Event.js

Line 16 in fa371d1

// flowlint unsafe-getters-setters:off

rubennorte · 2026-06-29T10:54:19Z

+   */
+  constructor() {
+    super();
+    throw new TypeError('AbortSignal cannot be constructed directly');


Could you please use the same pattern that we use in other DOM classes in RN to prevent them to be instantiated externally while being allowed internally? That would avoid the Flow issues in other parts of the code.

Could you please give an example ?

react-native/packages/react-native/src/private/webapis/geometry/DOMRectList.js

Line 81 in 6d3ebea

export const DOMRectList_public: typeof DOMRectList =

rubennorte · 2026-06-29T10:54:44Z

+ * Create an AbortSignal object.
+ */
+export function createAbortSignal(): AbortSignal {
+  const signal = Object.create(AbortSignal.prototype);


Please use const signal = new AbortSignal(). See my comment above about the pattern of private constructors.

rubennorte · 2026-06-29T10:55:45Z

+
+  abortedFlags.set(signal, true);
+  reasons.set(signal, reason);
+  // $FlowExpectedError[incompatible-type]


Why is this Flow suppression necessary?

doesn't need anymore, removed

retyui · 2026-06-29T11:56:17Z

@rubennorte All comments were fixed please review again

retyui · 2026-06-29T12:01:26Z

+
+import DOMException from '../../../errors/DOMException';
+import {AbortController} from '../AbortController';
+import {AbortSignal_public as AbortSignal} from '../AbortSignal';


tests based on AbortSignal_public class

retyui · 2026-06-29T12:02:21Z

-  () => require('abort-controller/dist/abort-controller').AbortSignal, // flowlint-line untyped-import:off
+  () =>
+    require('../../src/private/webapis/dom/abort-api/AbortSignal')
+      .AbortSignal_public, // flowlint-line untyped-import:off


RN uses a public interface , same as tests do
https://github.com/react/react-native/pull/57230/changes#r3491521247

rubennorte · 2026-06-29T12:29:47Z

+// Copy static properties so that callers accessing them via the public constructor (e.g. `AbortSignal.timeout(0)`) still work.
+// $FlowFixMe[unsafe-object-assign]
+// $FlowFixMe[not-an-object]
+['timeout', 'abort', 'any'].forEach(methodName => {


Might be better to use Object. getOwnPropertyNames() here

sure, code looks clear now

Object. getOwnPropertyNames(AbortSignal) // ['length', 'name', 'prototype', 'abort', 'any', 'timeout']

rubennorte · 2026-06-29T12:31:39Z

+    });
+  });
+
+  describe("'any' static method", () => {


Could you please also add tests for the static abort method?

yes, tests were added

rubennorte · 2026-06-29T12:32:10Z

+  }
+
+  /**
+   * AbortSignal cannot be constructed directly.


This comment is outdated. We should indicate this is the internal/private constructor

rubennorte · 2026-06-29T14:48:03Z

+
+  constructor() {
+    super();
+    abortedFlags.set(this, false);


Might just be easier to convert this into a WeakSet and call it abortedSignals.

Edit: actually, why don't we store this state in a private field in the signal itself? I think it'd be more efficient. Same for reasons.

Edit: actually, why don't we store this state in a private field in the signal itself? I think it'd be more efficient.

yes we can use private fields, I tried to keep this fork close to the orignal imlp. to avoid any unexpected breaking changes. so 7 years ago there wasn't any private fields and WeakMap works as alternative to make a private field.

Let me know if you agree to convert it to private fields

Yeah, let's convert them

@rubennorte actually, I have no idea how to abort a signal from an AbortController::abort() method
without exposing a public method to mutate that this.#aborted filed

Oh, that's fair. You can use a symbol property instead of a private method, the same way we did in EventTarget. Check EventInternals. As an added benefit, that method is actually faster than private properties atm.

rubennorte · 2026-06-29T14:49:41Z

Sorry I missed some details in the original review about the weakmaps for signal state. Can you take a look please?

…AbortSignal.timeout(time)`

retyui · 2026-06-30T07:16:58Z

@rubennorte would you mind to review it again ?

rubennorte · 2026-06-30T09:38:32Z

+  signal[ABORTED_KEY] = true;
+  // $FlowExpectedError[prop-missing]
+  signal[REASON_KEY] = reason;
+  signal.dispatchEvent(new Event('abort'));


This should be a trusted event, so it should be dispatched via dispatchTrustedEvent (see EventTargetInternals).

rubennorte

There's just one detail that I can fix on my end. Thanks for the contribution and iterating on this, @retyui !

meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 16, 2026

facebook-github-tools Bot added p: Callstack Partner: Callstack Partner labels Jun 16, 2026

retyui force-pushed the feat/retyui/abort-api branch from c73abf7 to bc9cea8 Compare June 16, 2026 14:44

facebook-github-tools Bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Jun 16, 2026

retyui commented Jun 16, 2026

View reviewed changes

Comment thread packages/react-native/src/types/globals.d.ts

retyui commented Jun 17, 2026

View reviewed changes

Comment thread packages/react-native/src/private/webapis/dom/abort-api/AbortController.js Outdated

retyui commented Jun 17, 2026

View reviewed changes

Comment thread packages/react-native/src/private/webapis/dom/abort-api/__tests__/abort-api-test.js Outdated

cortinico requested a review from rubennorte June 17, 2026 16:06

retyui mentioned this pull request Jun 17, 2026

fix: Make EventTarget methods enumerable #57247

Closed

retyui force-pushed the feat/retyui/abort-api branch from bc9cea8 to c64a914 Compare June 22, 2026 10:14

rubennorte reviewed Jun 29, 2026

View reviewed changes

rubennorte requested changes Jun 29, 2026

View reviewed changes

rubennorte reviewed Jun 29, 2026

View reviewed changes

retyui force-pushed the feat/retyui/abort-api branch from c64a914 to 14ae1b0 Compare June 29, 2026 11:55

retyui requested a review from rubennorte June 29, 2026 11:55

retyui force-pushed the feat/retyui/abort-api branch from 14ae1b0 to d7756d6 Compare June 29, 2026 12:00

retyui commented Jun 29, 2026

View reviewed changes

rubennorte reviewed Jun 29, 2026

View reviewed changes

retyui force-pushed the feat/retyui/abort-api branch from d7756d6 to ed56991 Compare June 29, 2026 14:37

retyui requested a review from rubennorte June 29, 2026 14:38

rubennorte reviewed Jun 29, 2026

View reviewed changes

retyui force-pushed the feat/retyui/abort-api branch 2 times, most recently from 8c8e3e5 to d754299 Compare June 29, 2026 16:06

retyui added 2 commits June 30, 2026 09:15

Fork abort-controller to react-native repo

fee2fe4

feat: Add AbortSignal.any(signals), signal.throwIfAborted() and `…

b3594af

…AbortSignal.timeout(time)`

retyui force-pushed the feat/retyui/abort-api branch from d754299 to b3594af Compare June 30, 2026 07:16

rubennorte reviewed Jun 30, 2026

View reviewed changes

rubennorte approved these changes Jun 30, 2026

View reviewed changes

Uh oh!

Conversation

retyui commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary:

Changelog:

Test Plan:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

retyui commented Jun 22, 2026

Uh oh!

retyui commented Jun 29, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

meta-codesync Bot commented Jun 29, 2026

Uh oh!

rubennorte left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rubennorte Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

retyui commented Jun 29, 2026

Uh oh!

retyui Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

retyui Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

retyui commented Jun 16, 2026 •

edited

Loading

rubennorte Jun 29, 2026 •

edited

Loading

retyui Jun 29, 2026 •

edited

Loading

retyui Jun 29, 2026 •

edited

Loading

rubennorte Jun 29, 2026 •

edited

Loading

retyui Jun 29, 2026 •

edited

Loading