Export RCTDidInitializeModuleNotificationModuleKey for the module userInfo key#57341
Closed
eapen wants to merge 1 commit into
Closed
Export RCTDidInitializeModuleNotificationModuleKey for the module userInfo key#57341eapen wants to merge 1 commit into
module userInfo key#57341eapen wants to merge 1 commit into
Conversation
…serInfo key Summary: Add `RCTDidInitializeModuleNotificationModuleKey` to `RCTConstants.h`/`.m` so observers of `RCTDidInitializeModuleNotification` can read the module out of `userInfo` via a named constant instead of the bare `@"module"` literal. Update the poster in `RCTTurboModuleManager.mm` to use the new symbol so producer and consumer share a single source of truth. This follows the existing naming convention in `RCTConstants.h` (`RCTUserInterfaceStyleDidChangeNotificationTraitCollectionKey`). Purely additive — no existing API affected. Changelog: [iOS][Added] - Export `RCTDidInitializeModuleNotificationModuleKey` constant for `RCTDidInitializeModuleNotification` userInfo Differential Revision: D109716080
meta-cla
Bot
added
the
CLA Signed
|
@eapen has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109716080. |
|
This pull request has been merged in 217ee52. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add
RCTDidInitializeModuleNotificationModuleKeytoRCTConstants.h/.mso observers ofRCTDidInitializeModuleNotificationcan read the module out ofuserInfovia a named constant instead of the bare@"module"literal. Update the poster inRCTTurboModuleManager.mmto use the new symbol so producer and consumer share a single source of truth.This follows the existing naming convention in
RCTConstants.h(RCTUserInterfaceStyleDidChangeNotificationTraitCollectionKey).Purely additive — no existing API affected.
Changelog:
[iOS][Added] - Export
RCTDidInitializeModuleNotificationModuleKeyconstant forRCTDidInitializeModuleNotificationuserInfoDifferential Revision: D109716080