From 96bae4ff6a38c43ec1d0b900a020448fad2adb4d Mon Sep 17 00:00:00 2001 From: Wren Turkal Date: Thu, 12 Mar 2026 20:54:36 -0700 Subject: [PATCH] Run clippy against Arm build targets. The current clippy runs are running against an X86 build of the code This will make clippy exercise the Arm specfic code. I have only enabled 2 as some jobs were cancelled when I enabled all 7 targets. --- .github/workflows/clippy.yml | 42 +++++++++++++++++++++++++++++++++--- 1 file changed, 39 insertions(+), 3 deletions(-) diff --git a/.github/workflows/clippy.yml b/.github/workflows/clippy.yml index d40ee318..76bff0f1 100644 --- a/.github/workflows/clippy.yml +++ b/.github/workflows/clippy.yml @@ -5,11 +5,47 @@ on: name: Clippy check jobs: - clippy: + clippy_std_code: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - uses: dtolnay/rust-toolchain@1.85 + - uses: dtolnay/rust-toolchain@1.94.0 with: + # toolchain: 1.94.0 + # target: thumbv8m.main-none-eabihf components: clippy - - run: cargo clippy --all --features cortex-m/critical-section-single-core -- --deny warnings + - name: Run clippy + run: cargo clippy --all --features cortex-m/critical-section-single-core -- --deny warnings + clippy_cortex_crates: + runs-on: ubuntu-latest + continue-on-error: true + strategy: + matrix: + # All generated code should be running on stable now + rust: [1.94.0] + target: + [ + "thumbv8m.main-none-eabihf", + "thumbv8m.main-none-eabi", + "thumbv8m.base-none-eabi", + + "thumbv7em-none-eabihf", + "thumbv7em-none-eabi", + "thumbv7m-none-eabi", + + "thumbv6m-none-eabi", + ] + + # # Test nightly but don't fail + # - rust: nightly + # experimental: true + steps: + - uses: actions/checkout@v4 + - uses: dtolnay/rust-toolchain@master + with: + toolchain: ${{ matrix.rust }} + target: ${{ matrix.target }} + components: clippy + - name: Run clippy + run: cargo clippy --all --exclude testsuite --exclude xtask --features cortex-m/critical-section-single-core --target ${{matrix.target}} -- --deny warnings + # run: cargo clippy --all --features cortex-m/critical-section-single-core -- --deny warnings