-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
Drop support for DebuggerTools being invoked from the top-level bootstrap CLI #95992
Copy link
Copy link
Closed
Labels
E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Metadata
Metadata
Assignees
Labels
E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Type
Fields
Give feedbackNo fields configured for issues without a type.
@Mark-Simulacrum mentioned we'd also need some work to ensure they're in dist tarballs, but it looks like they're already present:
rust/src/bootstrap/dist.rs
Lines 433 to 435 in 52ca603
So I think this is as simple as changing
rust/src/bootstrap/dist.rs
Lines 455 to 459 in 52ca603
run.never()and deletingrust/src/bootstrap/builder.rs
Line 581 in 52ca603
Originally posted by @Mark-Simulacrum in #95906 (comment)