Skip to content

Commit 94e2506

Browse files
authored
Merge pull request #166 from salesforcecli/ew/safely-remove-npm-checks
@W-22957336: remove checks for unpublished packages
2 parents 39f8692 + 5140352 commit 94e2506

1 file changed

Lines changed: 5 additions & 101 deletions

File tree

.github/workflows/npmPublish.yml

Lines changed: 5 additions & 101 deletions
Original file line numberDiff line numberDiff line change
@@ -148,109 +148,12 @@ jobs:
148148
uses: salesforcecli/github-workflows/.github/actions/npmInstallWithRetries@main
149149
- name: Vulnerability check
150150
if: inputs.vulnerabilityCheck
151-
# Temporary check for known vulnerable packages from the following supply chain attacks:
151+
# Check for known vulnerable packages from the following supply chain attacks:
152152
run: |
153153
vulns=(
154-
# https://www.sonatype.com/blog/npm-chalk-and-debug-packages-hit-in-software-supply-chain-attack
155-
# Last updated 10:33 a.m. ET on September 9, 2025
156-
"@coveops/abi@2.0.1"
157-
"@duckdb/duckdb-wasm@1.29.2"
158-
"@duckdb/node-api@1.3.3"
159-
"@duckdb/node-bindings@1.3.3"
160-
"ansi-regex@6.2.1"
161-
"ansi-styles@6.2.2"
162-
"backslash@0.2.1"
154+
# keeping one past (unpublished) check as an example
155+
# Add new vulns here as a quick deny-list
163156
"chalk@5.6.1"
164-
"chalk-template@1.1.1"
165-
"color@5.0.1"
166-
"color-convert@3.1.1"
167-
"color-name@2.0.1"
168-
"color-string@2.1.1"
169-
"debug@4.4.2"
170-
"duckdb@1.3.3"
171-
"error-ex@1.3.3"
172-
"has-ansi@6.0.1"
173-
"is-arrayish@0.3.3"
174-
"prebid@10.9.2"
175-
"prebid-universal-creative@1.17.3"
176-
"prebid.js@10.9.2"
177-
"proto-tinker-wc@0.1.87"
178-
"simple-swizzle@0.2.3"
179-
"slice-ansi@7.1.1"
180-
"strip-ansi@7.1.1"
181-
"supports-color@10.2.1"
182-
"supports-hyperlinks@4.1.1"
183-
"wrap-ansi@9.0.1"
184-
# https://socket.dev/blog/tinycolor-supply-chain-attack-affects-40-packages
185-
# Last updated 10:40 a.m. ET on September 16, 2025
186-
"angulartics2@14.1.2"
187-
"@ctrl/deluge@7.2.2"
188-
"@ctrl/golang-template@1.4.3"
189-
"@ctrl/magnet-link@4.0.4"
190-
"@ctrl/ngx-codemirror@7.0.2"
191-
"@ctrl/ngx-csv@6.0.2"
192-
"@ctrl/ngx-emoji-mart@9.2.2"
193-
"@ctrl/ngx-rightclick@4.0.2"
194-
"@ctrl/qbittorrent@9.7.2"
195-
"@ctrl/react-adsense@2.0.2"
196-
"@ctrl/shared-torrent@6.3.2"
197-
"@ctrl/tinycolor@4.1.1"
198-
"@ctrl/tinycolor@4.1.2"
199-
"@ctrl/torrent-file@4.1.2"
200-
"@ctrl/transmission@7.3.1"
201-
"@ctrl/ts-base32@4.0.2"
202-
"encounter-playground@0.0.5"
203-
"json-rules-engine-simplified@0.2.1"
204-
"json-rules-engine-simplified@0.2.4"
205-
"koa2-swagger-ui@5.11.1"
206-
"koa2-swagger-ui@5.11.2"
207-
"@nativescript-community/gesturehandler@2.0.35"
208-
"@nativescript-community/sentry 4.6.43"
209-
"@nativescript-community/text@1.6.13"
210-
"@nativescript-community/ui-collectionview@6.0.6"
211-
"@nativescript-community/ui-drawer@0.1.30"
212-
"@nativescript-community/ui-image@4.5.6"
213-
"@nativescript-community/ui-material-bottomsheet@7.2.72"
214-
"@nativescript-community/ui-material-core@7.2.76"
215-
"@nativescript-community/ui-material-core-tabs@7.2.76"
216-
"ngx-color@10.0.2"
217-
"ngx-toastr@19.0.2"
218-
"ngx-trend@8.0.1"
219-
"react-complaint-image@0.0.35"
220-
"react-jsonschema-form-conditionals@0.3.21"
221-
"react-jsonschema-form-extras@1.0.4"
222-
"rxnt-authentication@0.0.6"
223-
"rxnt-healthchecks-nestjs@1.0.5"
224-
"rxnt-kue@1.0.7"
225-
"swc-plugin-component-annotate@1.9.2"
226-
"ts-gaussian@3.0.6"
227-
# https://socket.dev/blog/ongoing-supply-chain-attack-targets-crowdstrike-npm-packages
228-
# Last updated 10:40 a.m. ET on September 16, 2025
229-
"@crowdstrike/commitlint@8.1.1"
230-
"@crowdstrike/commitlint@8.1.2"
231-
"@crowdstrike/falcon-shoelace@0.4.2"
232-
"@crowdstrike/foundry-js@0.19.2"
233-
"@crowdstrike/glide-core@0.34.2"
234-
"@crowdstrike/glide-core@0.34.3"
235-
"@crowdstrike/logscale-dashboard@1.205.2"
236-
"@crowdstrike/logscale-file-editor@1.205.2"
237-
"@crowdstrike/logscale-parser-edit@1.205.1"
238-
"@crowdstrike/logscale-parser-edit@1.205.2"
239-
"@crowdstrike/logscale-search@1.205.2"
240-
"@crowdstrike/tailwind-toucan-base@5.0.2"
241-
"browser-webdriver-downloader@3.0.8"
242-
"ember-browser-services@5.0.3"
243-
"ember-headless-form-yup@1.0.1"
244-
"ember-headless-form@1.1.3"
245-
"ember-headless-table@2.1.6"
246-
"ember-url-hash-polyfill@1.0.13"
247-
"ember-velcro@2.2.2"
248-
"eslint-config-crowdstrike-node@4.0.4"
249-
"eslint-config-crowdstrike@11.0.3"
250-
"monorepo-next@13.0.2"
251-
"remark-preset-lint-crowdstrike@4.0.2"
252-
"verror-extra@6.0.1"
253-
"yargs-help-output@5.0.3"
254157
)
255158
256159
for vuln in "${vulns[@]}"; do
@@ -262,7 +165,8 @@ jobs:
262165
fi
263166
done
264167
265-
# Known string from the exploit
168+
# Known string from exploits
169+
# This is a past known example, leaving it hear as an example
266170
# https://github.com/chalk/chalk/issues/656#issuecomment-3266880534
267171
strings=(
268172
"_0x112fa8"

0 commit comments

Comments
 (0)