Share Rubocop versions

Author: alexeyr

.rubocop.yml

@@ -32,6 +32,7 @@ AllCops:
 Naming/FileName:
   Exclude:
     - '**/Gemfile'
+    - '**/Gemfile.*'
     - '**/Rakefile'
 
 Layout/LineLength:

Gemfile.shared_dev_dependencies

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+# Shared development dependencies for react_on_rails and react_on_rails_pro
+# This ensures consistent versions across the monorepo
+
+group :development, :test do
+  gem "rubocop", "1.61.0", require: false
+  gem "rubocop-performance", "~>1.20.0", require: false
+  gem "rubocop-rspec", "~>2.26", require: false
+end

react_on_rails/Gemfile.development_dependencies

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+eval_gemfile File.expand_path("../Gemfile.shared_dev_dependencies", __dir__)
+
 gem "shakapacker", "9.4.0"
 gem "bootsnap", require: false
 gem "rails", "~> 7.1"
@@ -35,9 +37,6 @@ group :development, :test do
   gem "pry-rescue"
   gem "rbs", require: false
   gem "steep", require: false
-  gem "rubocop", "1.61.0", require: false
-  gem "rubocop-performance", "~>1.20.0", require: false
-  gem "rubocop-rspec", "~>2.26", require: false
   gem "spring", "~> 4.0"
   gem "lefthook", require: false
   # Added for Ruby 3.5+ compatibility to silence warnings

react_on_rails_pro/Gemfile

@@ -5,4 +5,8 @@ source "https://rubygems.org"
 # Specify your gem"s dependencies in react_on_rails.gemspec
 gemspec
 
+# Shared dev dependencies must be loaded here (not in Gemfile.development_dependencies)
+# because Gemfile.loader uses eval() which breaks __dir__ resolution
+eval_gemfile File.expand_path("../Gemfile.shared_dev_dependencies", __dir__)
+
 eval_gemfile File.expand_path("./Gemfile.loader", __dir__)

react_on_rails_pro/Gemfile.development_dependencies

@@ -1,6 +1,10 @@
 # Keep in sync with https://github.com/shakacode/react_on_rails/blob/master/Gemfile.development_dependencies
 # frozen_string_literal: true
 
+# NOTE: Shared dev dependencies (rubocop, etc.) are loaded via eval_gemfile in
+# the main Gemfile, not here. This is because Gemfile.loader uses eval() which
+# breaks __dir__ resolution for eval_gemfile calls.
+
 git_source(:github) { |repo| "https://github.com/#{repo}.git" }
 
 ruby '3.3.7'
@@ -51,9 +55,6 @@ group :development, :test do
   gem 'pry-theme' # An easy way to customize Pry colors via theme files
 
   gem "rbs", require: false
-  gem "rubocop", "1.36.0", require: false
-  gem 'rubocop-performance', "1.15.0", require: false
-  gem 'rubocop-rspec', "2.13.2", require: false
   gem "scss_lint", require: false
   gem 'fakefs', require: 'fakefs/safe'
 end

react_on_rails_pro/Gemfile.lock

@@ -110,7 +110,7 @@ GEM
     addressable (2.8.8)
       public_suffix (>= 2.0.2, < 8.0)
     amazing_print (1.6.0)
-    ast (2.4.2)
+    ast (2.4.3)
     async (2.35.0)
       console (~> 1.29)
       fiber-annotation
@@ -208,6 +208,7 @@ GEM
     json (2.17.1)
     jwt (2.10.2)
       base64
+    language_server-protocol (3.17.0.5)
     launchy (3.0.1)
       addressable (~> 2.8)
       childprocess (~> 5.0)
@@ -252,14 +253,15 @@ GEM
     nokogiri (1.18.10-x86_64-linux-gnu)
       racc (~> 1.4)
     package_json (0.2.0)
-    parallel (1.25.1)
-    parser (3.3.3.0)
+    parallel (1.27.0)
+    parser (3.3.10.0)
       ast (~> 2.4.1)
       racc
     pg (1.5.6)
     pp (0.6.3)
       prettyprint
     prettyprint (0.2.0)
+    prism (1.6.0)
     protocol (2.0.0)
       ruby_parser (~> 3.0)
     pry (0.14.2)
@@ -356,23 +358,34 @@ GEM
     rspec-support (3.13.1)
     rspec_junit_formatter (0.6.0)
       rspec-core (>= 2, < 4, != 2.12.0)
-    rubocop (1.36.0)
+    rubocop (1.61.0)
       json (~> 2.3)
+      language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
-      parser (>= 3.1.2.1)
+      parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.20.1, < 2.0)
+      rubocop-ast (>= 1.30.0, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.31.3)
-      parser (>= 3.3.1.0)
-    rubocop-performance (1.15.0)
-      rubocop (>= 1.7.0, < 2.0)
-      rubocop-ast (>= 0.4.0)
-    rubocop-rspec (2.13.2)
-      rubocop (~> 1.33)
+      unicode-display_width (>= 2.4.0, < 3.0)
+    rubocop-ast (1.48.0)
+      parser (>= 3.3.7.2)
+      prism (~> 1.4)
+    rubocop-capybara (2.21.0)
+      rubocop (~> 1.41)
+    rubocop-factory_bot (2.26.1)
+      rubocop (~> 1.61)
+    rubocop-performance (1.20.2)
+      rubocop (>= 1.48.1, < 2.0)
+      rubocop-ast (>= 1.30.0, < 2.0)
+    rubocop-rspec (2.31.0)
+      rubocop (~> 1.40)
+      rubocop-capybara (~> 2.17)
+      rubocop-factory_bot (~> 2.22)
+      rubocop-rspec_rails (~> 2.28)
+    rubocop-rspec_rails (2.29.1)
+      rubocop (~> 1.61)
     ruby-progressbar (1.13.0)
     ruby_parser (3.21.0)
       racc (~> 1.5)
@@ -402,7 +415,7 @@ GEM
       websocket (~> 1.0)
     semantic_range (3.1.0)
     sexp_processor (4.17.1)
-    shakapacker (9.3.0)
+    shakapacker (9.4.0)
       activesupport (>= 5.2)
       package_json
       rack-proxy (>= 0.6.1)
@@ -447,7 +460,7 @@ GEM
       concurrent-ruby (~> 1.0)
     uglifier (4.2.0)
       execjs (>= 0.3.0, < 3)
-    unicode-display_width (2.5.0)
+    unicode-display_width (2.6.0)
     uri (1.0.3)
     useragent (0.16.11)
     web-console (4.2.1)
@@ -513,13 +526,13 @@ DEPENDENCIES
   rspec-rails
   rspec-retry
   rspec_junit_formatter
-  rubocop (= 1.36.0)
-  rubocop-performance (= 1.15.0)
-  rubocop-rspec (= 2.13.2)
+  rubocop (= 1.61.0)
+  rubocop-performance (~> 1.20.0)
+  rubocop-rspec (~> 2.26)
   sass-rails
   scss_lint
   selenium-webdriver (= 4.9.0)
-  shakapacker (= 9.3.0)
+  shakapacker (= 9.4.0)
   spring
   spring-watcher-listen
   sprockets

react_on_rails_pro/spec/dummy/Gemfile.lock

@@ -108,7 +108,6 @@ GEM
     addressable (2.8.7)
       public_suffix (>= 2.0.2, < 7.0)
     amazing_print (1.6.0)
-    ast (2.4.2)
     async (2.34.0)
       console (~> 1.29)
       fiber-annotation
@@ -272,10 +271,6 @@ GEM
     nokogiri (1.18.10-x86_64-linux-musl)
       racc (~> 1.4)
     package_json (0.2.0)
-    parallel (1.25.1)
-    parser (3.3.3.0)
-      ast (~> 2.4.1)
-      racc
     pg (1.5.6)
     pp (0.6.3)
       prettyprint
@@ -380,24 +375,6 @@ GEM
     rspec-support (3.13.1)
     rspec_junit_formatter (0.6.0)
       rspec-core (>= 2, < 4, != 2.12.0)
-    rubocop (1.36.0)
-      json (~> 2.3)
-      parallel (~> 1.10)
-      parser (>= 3.1.2.1)
-      rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.8, < 3.0)
-      rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.20.1, < 2.0)
-      ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.31.3)
-      parser (>= 3.3.1.0)
-    rubocop-performance (1.15.0)
-      rubocop (>= 1.7.0, < 2.0)
-      rubocop-ast (>= 0.4.0)
-    rubocop-rspec (2.13.2)
-      rubocop (~> 1.33)
-    ruby-progressbar (1.13.0)
     ruby_parser (3.21.0)
       racc (~> 1.5)
       sexp_processor (~> 4.16)
@@ -476,7 +453,6 @@ GEM
       concurrent-ruby (~> 1.0)
     uglifier (4.2.0)
       execjs (>= 0.3.0, < 3)
-    unicode-display_width (2.5.0)
     uri (1.0.3)
     useragent (0.16.11)
     web-console (4.2.1)
@@ -555,9 +531,6 @@ DEPENDENCIES
   rspec-rails
   rspec-retry
   rspec_junit_formatter
-  rubocop (= 1.36.0)
-  rubocop-performance (= 1.15.0)
-  rubocop-rspec (= 2.13.2)
   sass-rails
   scss_lint
   selenium-webdriver (= 4.9.0)