Commit 2ddbe80
Trigger generator tests when TypeScript files change (#2208)
## Summary
- When TypeScript files in `packages/react-on-rails/` change, CI now
also triggers generator tests
- Generator tests perform a full build which catches TypeScript
compilation errors
## Problem (Fixes #2205)
PR #2125 changed TypeScript types in
`packages/react-on-rails/src/types/index.ts`, which exposed a latent
type error in `serverRenderReactComponent.ts`. This wasn't caught until
the release script ran `pnpm publish` which performs a fresh TypeScript
build.
The generator/example tests would have caught this because they run a
full build, but they weren't triggered because the CI change detection
didn't consider `packages/react-on-rails/**` changes as requiring
generator tests.
## Solution
Updated `script/ci-changes-detector` to trigger generator tests when
`JS_CHANGED=true` (which includes TypeScript file changes in
`packages/react-on-rails/src/`).
## Test plan
- [ ] Verify the script correctly detects TypeScript changes and sets
`run_generators=true`
- [ ] CI passes
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude <[email protected]>1 parent 1593bf9 commit 2ddbe80
1 file changed
+3
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
267 | 267 | | |
268 | 268 | | |
269 | 269 | | |
270 | | - | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
271 | 273 | | |
272 | 274 | | |
273 | 275 | | |
| |||
0 commit comments