From 9836ea411765df564d294bc056f28252761d47bb Mon Sep 17 00:00:00 2001 From: Justin Gordon Date: Wed, 10 Dec 2025 22:45:24 -1000 Subject: [PATCH] Trigger generator tests when TypeScript files change MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes #2205 When TypeScript files in packages/react-on-rails/ change, the CI change detector now triggers generator tests. This is important because generator tests do a full build, which catches TypeScript compilation errors that might otherwise slip through until npm publish time. The issue arose when PR #2125 changed TypeScript types but the resulting compilation error wasn't caught until the release script ran. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude --- script/ci-changes-detector | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/script/ci-changes-detector b/script/ci-changes-detector index 391a2d1429..14c5e9658d 100755 --- a/script/ci-changes-detector +++ b/script/ci-changes-detector @@ -267,7 +267,9 @@ if [ "$SPEC_DUMMY_CHANGED" = true ] || [ "$RUBY_CORE_CHANGED" = true ] || [ "$JS RUN_DUMMY_TESTS=true fi -if [ "$GENERATORS_CHANGED" = true ]; then +# JS changes trigger generator tests because generators do a full build +# which catches TypeScript compilation errors (see issue #2205) +if [ "$GENERATORS_CHANGED" = true ] || [ "$JS_CHANGED" = true ]; then RUN_GENERATORS=true fi