Skip to content

[BUG] Cannot Use Strategic Merge Patching for Build Steps #2013

@adambkaplan

Description

@adambkaplan

Is there an existing issue for this?

  • I have searched the existing issues

Kubernetes Version

v1.34.0

Shipwright Version

v0.17.0

Current Behavior

The ClusterBuildStrategy (and I assume BuildStrategy) APIs do not support strategic merge patching for build steps. This makes it impossible to install the sample build strategies with Kustomizations (ex: add additional resources to a build strategy). Using a patch that assumes strategic merge results in the build step being overwritten.

Expected Behavior

Build strategy step resources can be modified using a Kustomize strategic merge patch.

Steps To Reproduce

  1. Create a Kustomization that installs the sample build strategies from a release.
  2. Add a yaml patch file to the Kustomization that attempts to increase the resouce requests and limits.

See https://github.com/adambkaplan/quizap-deployments/tree/1054641748f9b897258ffdd359ccfd835a64e42f

Anything else?

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugCategorizes issue or PR as related to a bug.

    Type

    No type

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions