Skip to content

Commit a7c49e3

Browse files
committed
Fix: Settings overview should only be shown in the tournament Setup state
1 parent 204975f commit a7c49e3

File tree

4 files changed

+102
-1
lines changed

4 files changed

+102
-1
lines changed

CHANGELOG.md

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,24 @@
11
# 2025-11-17
22

3+
## **v4.0.14** - Match Controls Configuration Display Fix
4+
5+
### Bug Fixes
6+
- **Fixed tournament configuration display showing in active and completed tournament states**
7+
- **Issue**: Tournament configuration settings were visible in Match Controls during active and completed tournament states, not just setup mode
8+
- **Root cause**: The `updateTournamentConfigDisplay()` function was only called in the `'setup'` case but always set `display: 'block'`. Once shown, the configuration was never hidden when tournament status changed
9+
- **Fix**: Added explicit hide logic in both `'completed'` and `'active'` cases to ensure configuration display only appears during setup mode
10+
- **Behavior**:
11+
- **Setup mode**: Configuration display shows tournament settings (point values, match configuration, lanes)
12+
- **Active mode**: Configuration display hidden, referee suggestions shown
13+
- **Completed mode**: Configuration display hidden, tournament achievements shown
14+
- **Impact**:
15+
- ✅ Configuration settings only visible when relevant (setup mode)
16+
- ✅ Cleaner Match Controls interface during active tournaments
17+
- ✅ Consistent state-driven UI behavior across tournament lifecycle
18+
- **Files modified**: `js/bracket-rendering.js` (lines 3510-3511, 3520-3521)
19+
20+
---
21+
322
## **v4.0.13** - Results Table Column Width Adjustments
423

524
### UI Improvements

Docs/RELEASE-NOTES-v4.0.14.md

Lines changed: 74 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,74 @@
1+
## NewTon DC Tournament Manager v4.0.14 Release Notes
2+
3+
**Release Date:** November 17, 2025
4+
**Incremental Release**
5+
6+
---
7+
8+
## Overview
9+
10+
**NewTon DC Tournament Manager Version 4.0.14** fixes the tournament configuration display appearing incorrectly during active and completed tournament states in Match Controls.
11+
12+
This release contains no breaking changes and is a drop-in replacement for v4.0.13.
13+
14+
**Key Highlight:**
15+
- Configuration settings now only display during setup mode
16+
17+
---
18+
19+
## 🐛 Bug Fixes
20+
21+
**Match Controls Configuration Display Fix:**
22+
23+
Fixed tournament configuration settings showing in Match Controls during active and completed tournaments when they should only appear during setup mode.
24+
25+
**What Was Fixed:**
26+
- Configuration display now hidden when tournament is active
27+
- Configuration display now hidden when tournament is completed
28+
- Configuration display only visible during setup mode
29+
30+
**Why It Matters:**
31+
The configuration display provides quick reference to tournament settings during setup, but clutters the interface during active tournaments when operators need referee suggestions and match controls instead.
32+
33+
**Impact:**
34+
- Cleaner Match Controls during active tournaments
35+
- Configuration visible only when relevant
36+
- Proper state-driven UI behavior
37+
38+
---
39+
40+
## 🚀 Migration from v4.0.13
41+
42+
### Automatic
43+
- Fully compatible with all v4.0.x tournaments
44+
- No data migration required
45+
- No functional changes to existing tournament behavior
46+
- Display logic updates apply automatically
47+
48+
### What's New
49+
After upgrading to v4.0.14:
50+
1. **Match Controls shows correct content** - Configuration only in setup, referee suggestions during active play
51+
2. **No configuration needed** - State-based display works automatically
52+
53+
### Compatibility
54+
- All v4.0.x tournaments work in v4.0.14
55+
- No changes to tournament logic or data structures
56+
57+
---
58+
59+
## 📖 Additional Resources
60+
61+
- **CHANGELOG.md**: Detailed version history with technical implementation details
62+
- **Docs/RELEASE-NOTES-v4.0.13.md**: Results table column width adjustments
63+
- **Docs/RELEASE-NOTES-v4.0.12.md**: Configuration display and referee conflict fixes
64+
- **Docs/RELEASE-NOTES-v4.0.11.md**: Insignia Regular font and demo header spacing
65+
66+
---
67+
68+
## 🐛 Known Issues
69+
70+
None at time of release. Please report issues through GitHub repository.
71+
72+
---
73+
74+
**NewTon DC Tournament Manager v4.0.14** - Clean Match Controls interface.

js/bracket-rendering.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3505,13 +3505,21 @@ function showCommandCenterModal(matchData) {
35053505
case 'completed':
35063506
// Tournament completed - show achievements
35073507
showTournamentAchievements();
3508+
3509+
// Hide tournament configuration display (only shown in setup)
3510+
const configDisplayCompleted = document.getElementById('tournamentConfigDisplay');
3511+
if (configDisplayCompleted) configDisplayCompleted.style.display = 'none';
35083512
break;
35093513

35103514
case 'active':
35113515
default:
35123516
// Tournament active - show referee suggestions
35133517
if (refereeHeader) refereeHeader.textContent = '👥 Referee Suggestions';
35143518

3519+
// Hide tournament configuration display (only shown in setup)
3520+
const configDisplayActive = document.getElementById('tournamentConfigDisplay');
3521+
if (configDisplayActive) configDisplayActive.style.display = 'none';
3522+
35153523
// Reset subsection headers to their original values for active state
35163524
const losersSection = document.getElementById('refereeLosersSection');
35173525
const winnersSection = document.getElementById('refereeWinnersSection');

js/main.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ let matches = [];
77
let currentStatsPlayer = null;
88

99
// Application version
10-
const APP_VERSION = '4.0.13';
10+
const APP_VERSION = '4.0.14';
1111

1212
// Application identity (encoded)
1313
const _0x4e = [78,101,119,84,111,110,32,68,67,32,84,111,117,114];

0 commit comments

Comments
 (0)